Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump OctoKit to 10.0.0 #3333

Merged
merged 8 commits into from
Feb 23, 2024
Merged

Bump OctoKit to 10.0.0 #3333

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b4e2ac0
Update dependencies from https://github.com/dotnet/dnceng-shared buil…
dotnet-maestro[bot] Feb 23, 2024
edda345
Update dependencies from https://github.com/dotnet/dnceng-shared buil…
dotnet-maestro[bot] Feb 23, 2024
f3ee316
[main] Bump us to Octokit v10.0.0
dougbu Feb 23, 2024
4f47742
Update dependencies from https://github.com/dotnet/dnceng-shared buil…
dotnet-maestro[bot] Feb 23, 2024
254f460
Stop using a preview header
premun Feb 23, 2024
f211d08
Return a comment
premun Feb 23, 2024
c60ad9b
Sign assembly
premun Feb 23, 2024
820a332
Do not sign
premun Feb 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@
<PackageVersion Include="NuGet.Protocol" Version="6.7.1" />
<PackageVersion Include="NUnit" Version="4.0.1" />
<PackageVersion Include="NUnit3TestAdapter" Version="4.5.0" />
<PackageVersion Include="Octokit" Version="0.49.0" />
<PackageVersion Include="Octokit" Version="10.0.0" />
<PackageVersion Include="OpenTelemetry.Exporter.OpenTelemetryProtocol" Version="1.7.0" />
<PackageVersion Include="OpenTelemetry.Extensions.Hosting" Version="1.7.0" />
<PackageVersion Include="OpenTelemetry.Instrumentation.AspNetCore" Version="1.7.0" />
Expand All @@ -138,4 +138,4 @@
<PackageVersion Include="Verify.NUnit" Version="19.6" />
<PackageVersion Include="YamlDotNet" Version="13.7.1" />
</ItemGroup>
</Project>
</Project>
88 changes: 44 additions & 44 deletions eng/Version.Details.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,93 +1,93 @@
<?xml version="1.0" encoding="utf-8"?>
<Dependencies>
<ProductDependencies>
<Dependency Name="Microsoft.DotNet.Internal.Logging" Version="1.1.0-beta.24115.1">
<Dependency Name="Microsoft.DotNet.Internal.Logging" Version="1.1.0-beta.24122.2">
<Uri>https://github.com/dotnet/dnceng-shared</Uri>
<Sha>df30e41e199097ea3a95191ce592e53cc2b62a1a</Sha>
<Sha>4ee484519db441b6152dbac978fc3bfb9fbfd0a3</Sha>
</Dependency>
<Dependency Name="Microsoft.AspNetCore.ApiPagination" Version="1.1.0-beta.24115.1">
<Dependency Name="Microsoft.AspNetCore.ApiPagination" Version="1.1.0-beta.24122.2">
<Uri>https://github.com/dotnet/dnceng-shared</Uri>
<Sha>df30e41e199097ea3a95191ce592e53cc2b62a1a</Sha>
<Sha>4ee484519db441b6152dbac978fc3bfb9fbfd0a3</Sha>
</Dependency>
<Dependency Name="Microsoft.AspNetCore.ApiVersioning" Version="1.1.0-beta.24115.1">
<Dependency Name="Microsoft.AspNetCore.ApiVersioning" Version="1.1.0-beta.24122.2">
<Uri>https://github.com/dotnet/dnceng-shared</Uri>
<Sha>df30e41e199097ea3a95191ce592e53cc2b62a1a</Sha>
<Sha>4ee484519db441b6152dbac978fc3bfb9fbfd0a3</Sha>
</Dependency>
<Dependency Name="Microsoft.AspNetCore.ApiVersioning.Analyzers" Version="1.1.0-beta.24115.1">
<Dependency Name="Microsoft.AspNetCore.ApiVersioning.Analyzers" Version="1.1.0-beta.24122.2">
<Uri>https://github.com/dotnet/dnceng-shared</Uri>
<Sha>df30e41e199097ea3a95191ce592e53cc2b62a1a</Sha>
<Sha>4ee484519db441b6152dbac978fc3bfb9fbfd0a3</Sha>
</Dependency>
<Dependency Name="Microsoft.AspNetCore.ApiVersioning.Swashbuckle" Version="1.1.0-beta.24115.1">
<Dependency Name="Microsoft.AspNetCore.ApiVersioning.Swashbuckle" Version="1.1.0-beta.24122.2">
<Uri>https://github.com/dotnet/dnceng-shared</Uri>
<Sha>df30e41e199097ea3a95191ce592e53cc2b62a1a</Sha>
<Sha>4ee484519db441b6152dbac978fc3bfb9fbfd0a3</Sha>
</Dependency>
<Dependency Name="Microsoft.DncEng.CommandLineLib" Version="1.1.0-beta.24115.1">
<Dependency Name="Microsoft.DncEng.CommandLineLib" Version="1.1.0-beta.24122.2">
<Uri>https://github.com/dotnet/dnceng-shared</Uri>
<Sha>df30e41e199097ea3a95191ce592e53cc2b62a1a</Sha>
<Sha>4ee484519db441b6152dbac978fc3bfb9fbfd0a3</Sha>
</Dependency>
<Dependency Name="Microsoft.DncEng.Configuration.Extensions" Version="1.1.0-beta.24115.1">
<Dependency Name="Microsoft.DncEng.Configuration.Extensions" Version="1.1.0-beta.24122.2">
<Uri>https://github.com/dotnet/dnceng-shared</Uri>
<Sha>df30e41e199097ea3a95191ce592e53cc2b62a1a</Sha>
<Sha>4ee484519db441b6152dbac978fc3bfb9fbfd0a3</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.Authentication.Algorithms" Version="1.1.0-beta.24115.1">
<Dependency Name="Microsoft.DotNet.Authentication.Algorithms" Version="1.1.0-beta.24122.2">
<Uri>https://github.com/dotnet/dnceng-shared</Uri>
<Sha>df30e41e199097ea3a95191ce592e53cc2b62a1a</Sha>
<Sha>4ee484519db441b6152dbac978fc3bfb9fbfd0a3</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.GitHub.Authentication" Version="1.1.0-beta.24115.1">
<Dependency Name="Microsoft.DotNet.GitHub.Authentication" Version="1.1.0-beta.24122.2">
<Uri>https://github.com/dotnet/dnceng-shared</Uri>
<Sha>df30e41e199097ea3a95191ce592e53cc2b62a1a</Sha>
<Sha>4ee484519db441b6152dbac978fc3bfb9fbfd0a3</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.Internal.DependencyInjection.Testing" Version="1.1.0-beta.24115.1">
<Dependency Name="Microsoft.DotNet.Internal.DependencyInjection.Testing" Version="1.1.0-beta.24122.2">
<Uri>https://github.com/dotnet/dnceng-shared</Uri>
<Sha>df30e41e199097ea3a95191ce592e53cc2b62a1a</Sha>
<Sha>4ee484519db441b6152dbac978fc3bfb9fbfd0a3</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.Internal.DependencyInjection" Version="1.1.0-beta.24115.1">
<Dependency Name="Microsoft.DotNet.Internal.DependencyInjection" Version="1.1.0-beta.24122.2">
<Uri>https://github.com/dotnet/dnceng-shared</Uri>
<Sha>df30e41e199097ea3a95191ce592e53cc2b62a1a</Sha>
<Sha>4ee484519db441b6152dbac978fc3bfb9fbfd0a3</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.Internal.Health" Version="1.1.0-beta.24115.1">
<Dependency Name="Microsoft.DotNet.Internal.Health" Version="1.1.0-beta.24122.2">
<Uri>https://github.com/dotnet/dnceng-shared</Uri>
<Sha>df30e41e199097ea3a95191ce592e53cc2b62a1a</Sha>
<Sha>4ee484519db441b6152dbac978fc3bfb9fbfd0a3</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.Internal.Testing.DependencyInjection.Abstractions" Version="1.1.0-beta.24115.1">
<Dependency Name="Microsoft.DotNet.Internal.Testing.DependencyInjection.Abstractions" Version="1.1.0-beta.24122.2">
<Uri>https://github.com/dotnet/dnceng-shared</Uri>
<Sha>df30e41e199097ea3a95191ce592e53cc2b62a1a</Sha>
<Sha>4ee484519db441b6152dbac978fc3bfb9fbfd0a3</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.Internal.Testing.DependencyInjectionCodeGen" Version="1.1.0-beta.24115.1">
<Dependency Name="Microsoft.DotNet.Internal.Testing.DependencyInjectionCodeGen" Version="1.1.0-beta.24122.2">
<Uri>https://github.com/dotnet/dnceng-shared</Uri>
<Sha>df30e41e199097ea3a95191ce592e53cc2b62a1a</Sha>
<Sha>4ee484519db441b6152dbac978fc3bfb9fbfd0a3</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.Internal.Testing.Utility" Version="1.1.0-beta.24115.1">
<Dependency Name="Microsoft.DotNet.Internal.Testing.Utility" Version="1.1.0-beta.24122.2">
<Uri>https://github.com/dotnet/dnceng-shared</Uri>
<Sha>df30e41e199097ea3a95191ce592e53cc2b62a1a</Sha>
<Sha>4ee484519db441b6152dbac978fc3bfb9fbfd0a3</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.Kusto" Version="1.1.0-beta.24115.1">
<Dependency Name="Microsoft.DotNet.Kusto" Version="1.1.0-beta.24122.2">
<Uri>https://github.com/dotnet/dnceng-shared</Uri>
<Sha>df30e41e199097ea3a95191ce592e53cc2b62a1a</Sha>
<Sha>4ee484519db441b6152dbac978fc3bfb9fbfd0a3</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.Metrics" Version="1.1.0-beta.24115.1">
<Dependency Name="Microsoft.DotNet.Metrics" Version="1.1.0-beta.24122.2">
<Uri>https://github.com/dotnet/dnceng-shared</Uri>
<Sha>df30e41e199097ea3a95191ce592e53cc2b62a1a</Sha>
<Sha>4ee484519db441b6152dbac978fc3bfb9fbfd0a3</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.ServiceFabric.ServiceHost" Version="1.1.0-beta.24115.1">
<Dependency Name="Microsoft.DotNet.ServiceFabric.ServiceHost" Version="1.1.0-beta.24122.2">
<Uri>https://github.com/dotnet/dnceng-shared</Uri>
<Sha>df30e41e199097ea3a95191ce592e53cc2b62a1a</Sha>
<Sha>4ee484519db441b6152dbac978fc3bfb9fbfd0a3</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.Services.Utility" Version="1.1.0-beta.24115.1">
<Dependency Name="Microsoft.DotNet.Services.Utility" Version="1.1.0-beta.24122.2">
<Uri>https://github.com/dotnet/dnceng-shared</Uri>
<Sha>df30e41e199097ea3a95191ce592e53cc2b62a1a</Sha>
<Sha>4ee484519db441b6152dbac978fc3bfb9fbfd0a3</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.Web.Authentication" Version="1.1.0-beta.24115.1">
<Dependency Name="Microsoft.DotNet.Web.Authentication" Version="1.1.0-beta.24122.2">
<Uri>https://github.com/dotnet/dnceng-shared</Uri>
<Sha>df30e41e199097ea3a95191ce592e53cc2b62a1a</Sha>
<Sha>4ee484519db441b6152dbac978fc3bfb9fbfd0a3</Sha>
</Dependency>
<Dependency Name="ServiceFabricMocks" Version="1.1.0-beta.24115.1">
<Dependency Name="ServiceFabricMocks" Version="1.1.0-beta.24122.2">
<Uri>https://github.com/dotnet/dnceng-shared</Uri>
<Sha>df30e41e199097ea3a95191ce592e53cc2b62a1a</Sha>
<Sha>4ee484519db441b6152dbac978fc3bfb9fbfd0a3</Sha>
</Dependency>
<Dependency Name="CoreHealthMonitor" Version="1.1.0-beta.24115.1">
<Dependency Name="CoreHealthMonitor" Version="1.1.0-beta.24122.2">
<Uri>https://github.com/dotnet/dnceng-shared</Uri>
<Sha>df30e41e199097ea3a95191ce592e53cc2b62a1a</Sha>
<Sha>4ee484519db441b6152dbac978fc3bfb9fbfd0a3</Sha>
</Dependency>
</ProductDependencies>
<ToolsetDependencies>
Expand Down
44 changes: 22 additions & 22 deletions eng/Versions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,28 +15,28 @@
<MicrosoftDotNetGitIssueManagerVersion>8.0.0-beta.24113.2</MicrosoftDotNetGitIssueManagerVersion>
<MicrosoftDotNetVersionToolsVersion>8.0.0-beta.24113.2</MicrosoftDotNetVersionToolsVersion>
<MicrosoftNetTestSdkVersion>17.4.1</MicrosoftNetTestSdkVersion>
<MicrosoftDotNetInternalLoggingVersion>1.1.0-beta.24115.1</MicrosoftDotNetInternalLoggingVersion>
<MicrosoftAspNetCoreApiPaginationVersion>1.1.0-beta.24115.1</MicrosoftAspNetCoreApiPaginationVersion>
<MicrosoftAspNetCoreApiVersioningVersion>1.1.0-beta.24115.1</MicrosoftAspNetCoreApiVersioningVersion>
<MicrosoftAspNetCoreApiVersioningAnalyzersVersion>1.1.0-beta.24115.1</MicrosoftAspNetCoreApiVersioningAnalyzersVersion>
<MicrosoftAspNetCoreApiVersioningSwashbuckleVersion>1.1.0-beta.24115.1</MicrosoftAspNetCoreApiVersioningSwashbuckleVersion>
<MicrosoftDncEngCommandLineLibVersion>1.1.0-beta.24115.1</MicrosoftDncEngCommandLineLibVersion>
<MicrosoftDncEngConfigurationExtensionsVersion>1.1.0-beta.24115.1</MicrosoftDncEngConfigurationExtensionsVersion>
<MicrosoftDotNetAuthenticationAlgorithmsVersion>1.1.0-beta.24115.1</MicrosoftDotNetAuthenticationAlgorithmsVersion>
<MicrosoftDotNetGitHubAuthenticationVersion>1.1.0-beta.24115.1</MicrosoftDotNetGitHubAuthenticationVersion>
<MicrosoftDotNetInternalDependencyInjectionTestingVersion>1.1.0-beta.24115.1</MicrosoftDotNetInternalDependencyInjectionTestingVersion>
<MicrosoftDotNetInternalDependencyInjectionVersion>1.1.0-beta.24115.1</MicrosoftDotNetInternalDependencyInjectionVersion>
<MicrosoftDotNetInternalHealthVersion>1.1.0-beta.24115.1</MicrosoftDotNetInternalHealthVersion>
<MicrosoftDotNetInternalTestingDependencyInjectionAbstractionsVersion>1.1.0-beta.24115.1</MicrosoftDotNetInternalTestingDependencyInjectionAbstractionsVersion>
<MicrosoftDotNetInternalTestingDependencyInjectionCodeGenVersion>1.1.0-beta.24115.1</MicrosoftDotNetInternalTestingDependencyInjectionCodeGenVersion>
<MicrosoftDotNetInternalTestingUtilityVersion>1.1.0-beta.24115.1</MicrosoftDotNetInternalTestingUtilityVersion>
<MicrosoftDotNetKustoVersion>1.1.0-beta.24115.1</MicrosoftDotNetKustoVersion>
<MicrosoftDotNetMetricsVersion>1.1.0-beta.24115.1</MicrosoftDotNetMetricsVersion>
<MicrosoftDotNetServiceFabricServiceHostVersion>1.1.0-beta.24115.1</MicrosoftDotNetServiceFabricServiceHostVersion>
<MicrosoftDotNetServicesUtilityVersion>1.1.0-beta.24115.1</MicrosoftDotNetServicesUtilityVersion>
<MicrosoftDotNetWebAuthenticationVersion>1.1.0-beta.24115.1</MicrosoftDotNetWebAuthenticationVersion>
<ServiceFabricMocksVersion>1.1.0-beta.24115.1</ServiceFabricMocksVersion>
<CoreHealthMonitorVersion>1.1.0-beta.24115.1</CoreHealthMonitorVersion>
<MicrosoftDotNetInternalLoggingVersion>1.1.0-beta.24122.2</MicrosoftDotNetInternalLoggingVersion>
<MicrosoftAspNetCoreApiPaginationVersion>1.1.0-beta.24122.2</MicrosoftAspNetCoreApiPaginationVersion>
<MicrosoftAspNetCoreApiVersioningVersion>1.1.0-beta.24122.2</MicrosoftAspNetCoreApiVersioningVersion>
<MicrosoftAspNetCoreApiVersioningAnalyzersVersion>1.1.0-beta.24122.2</MicrosoftAspNetCoreApiVersioningAnalyzersVersion>
<MicrosoftAspNetCoreApiVersioningSwashbuckleVersion>1.1.0-beta.24122.2</MicrosoftAspNetCoreApiVersioningSwashbuckleVersion>
<MicrosoftDncEngCommandLineLibVersion>1.1.0-beta.24122.2</MicrosoftDncEngCommandLineLibVersion>
<MicrosoftDncEngConfigurationExtensionsVersion>1.1.0-beta.24122.2</MicrosoftDncEngConfigurationExtensionsVersion>
<MicrosoftDotNetAuthenticationAlgorithmsVersion>1.1.0-beta.24122.2</MicrosoftDotNetAuthenticationAlgorithmsVersion>
<MicrosoftDotNetGitHubAuthenticationVersion>1.1.0-beta.24122.2</MicrosoftDotNetGitHubAuthenticationVersion>
<MicrosoftDotNetInternalDependencyInjectionTestingVersion>1.1.0-beta.24122.2</MicrosoftDotNetInternalDependencyInjectionTestingVersion>
<MicrosoftDotNetInternalDependencyInjectionVersion>1.1.0-beta.24122.2</MicrosoftDotNetInternalDependencyInjectionVersion>
<MicrosoftDotNetInternalHealthVersion>1.1.0-beta.24122.2</MicrosoftDotNetInternalHealthVersion>
<MicrosoftDotNetInternalTestingDependencyInjectionAbstractionsVersion>1.1.0-beta.24122.2</MicrosoftDotNetInternalTestingDependencyInjectionAbstractionsVersion>
<MicrosoftDotNetInternalTestingDependencyInjectionCodeGenVersion>1.1.0-beta.24122.2</MicrosoftDotNetInternalTestingDependencyInjectionCodeGenVersion>
<MicrosoftDotNetInternalTestingUtilityVersion>1.1.0-beta.24122.2</MicrosoftDotNetInternalTestingUtilityVersion>
<MicrosoftDotNetKustoVersion>1.1.0-beta.24122.2</MicrosoftDotNetKustoVersion>
<MicrosoftDotNetMetricsVersion>1.1.0-beta.24122.2</MicrosoftDotNetMetricsVersion>
<MicrosoftDotNetServiceFabricServiceHostVersion>1.1.0-beta.24122.2</MicrosoftDotNetServiceFabricServiceHostVersion>
<MicrosoftDotNetServicesUtilityVersion>1.1.0-beta.24122.2</MicrosoftDotNetServicesUtilityVersion>
<MicrosoftDotNetWebAuthenticationVersion>1.1.0-beta.24122.2</MicrosoftDotNetWebAuthenticationVersion>
<ServiceFabricMocksVersion>1.1.0-beta.24122.2</ServiceFabricMocksVersion>
<CoreHealthMonitorVersion>1.1.0-beta.24122.2</CoreHealthMonitorVersion>
<MicrosoftDncEngSecretManagerVersion>1.1.0-beta.24115.1</MicrosoftDncEngSecretManagerVersion>
<MicrosoftDncEngConfigurationBootstrapVersion>1.1.0-beta.24115.1</MicrosoftDncEngConfigurationBootstrapVersion>
</PropertyGroup>
Expand Down
7 changes: 2 additions & 5 deletions src/Maestro/Maestro.Web/Controllers/WebHooksController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,13 +132,10 @@ private static Task<IReadOnlyList<Repository>> GetAllInstallationRepositories(st
var pagination = new ApiPagination();
var uri = new Uri("installation/repositories", UriKind.Relative);

async Task<IApiResponse<List<Repository>>> GetInstallationRepositories(Uri u)
async Task<IApiResponse<List<Repository>>> GetInstallationRepositories(Uri requestUri)
{
IApiResponse<InstallationRepositoriesResponse> response =
await client.Connection.Get<InstallationRepositoriesResponse>(
u,
null,
AcceptHeaders.GitHubAppsPreview);
await client.Connection.Get<InstallationRepositoriesResponse>(requestUri, parameters: null);
return new ApiResponse<List<Repository>>(response.HttpResponse, response.Body.Repositories);
}

Expand Down
2 changes: 1 addition & 1 deletion src/Maestro/Microsoft.DotNet.Maestro.Tasks/Microsoft.DotNet.Maestro.Tasks.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<Description>This package include tasks involving Maestro++ and the Build Asset Registry.</Description>
<DevelopmentDependency>true</DevelopmentDependency>
<PackageType>MSBuildSdk</PackageType>
<!-- Octokit is not strong named yet (https://github.com/octokit/octokit.net/blob/master/docs/strong-naming.md) -->
premun marked this conversation as resolved.
Show resolved Hide resolved
<!-- Octokit used to be not strong named. It is now, we should remove this -->
<SignAssembly>false</SignAssembly>
<!-- Build Tasks should not include any dependencies -->
<SuppressDependenciesWhenPacking>true</SuppressDependenciesWhenPacking>
Expand Down
Loading