Fixing PR

dotnet · Nov 13, 2023 · b2719d5 · b2719d5
1 parent 241fad6
commit b2719d5
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 4 deletions.
diff --git a/src/Microsoft.DotNet.Build.Tasks.Feed.Tests/SetupTargetFeedConfigV3Tests.cs b/src/Microsoft.DotNet.Build.Tasks.Feed.Tests/SetupTargetFeedConfigV3Tests.cs
@@ -326,6 +326,7 @@ public void NonStableAndPublic(bool publishInstallersAndChecksums)
                     TargetFeedContentType.Symbols,
                     PublishingConstants.LegacyDotNetBlobFeedURL,
                     FeedType.AzureStorageFeed,
+                    InstallersTargetStaticFeedKey,
                     latestLinkShortUrlPrefix: string.Empty,
                     assetSelection: AssetSelection.All,
                     isolated: false,

diff --git a/src/Microsoft.DotNet.Build.Tasks.Feed/src/model/SetupTargetFeedConfigBase.cs b/src/Microsoft.DotNet.Build.Tasks.Feed/src/model/SetupTargetFeedConfigBase.cs
@@ -28,7 +28,6 @@ protected SetupTargetFeedConfigBase(bool isInternalBuild,
             bool isStableBuild,
             string repositoryName,
             string commitSha,
-            string azureStorageTargetFeedPAT,
             bool publishInstallersAndChecksums,
             string installersTargetStaticFeed,
             string installersAzureAccountKey,
@@ -44,7 +43,6 @@ protected SetupTargetFeedConfigBase(bool isInternalBuild,
             IsStableBuild = isStableBuild;
             RepositoryName = repositoryName;
             CommitSha = commitSha;
-            AzureStorageTargetFeedPAT = azureStorageTargetFeedPAT;
             PublishInstallersAndChecksums = publishInstallersAndChecksums;
             InstallersTargetStaticFeed = installersTargetStaticFeed;
             InstallersAzureAccountKey = installersAzureAccountKey;

diff --git a/src/Microsoft.DotNet.Build.Tasks.Feed/src/model/SetupTargetFeedConfigV3.cs b/src/Microsoft.DotNet.Build.Tasks.Feed/src/model/SetupTargetFeedConfigV3.cs
@@ -154,7 +154,7 @@ private List<TargetFeedConfig> NonStableFeeds()
             // This is pretty uncommon though, as non-stable internal builds are quite rare.
             string symbolsFeed;
             FeedType symbolsFeedType;
-            string symbolsFeedSecret;
+            string symbolsFeedSecret = string.Empty;
 
             if (IsInternalBuild)
             {

diff --git a/...rosoft.DotNet.SwaggerGenerator/Microsoft.DotNet.SwaggerGenerator.CodeGenerator/Helpers.cs b/...rosoft.DotNet.SwaggerGenerator/Microsoft.DotNet.SwaggerGenerator.CodeGenerator/Helpers.cs
@@ -15,7 +15,7 @@ public static class Helpers
         ///   A 'word' is the next logical piece of a variable/property/parameter name
         /// </remarks>
         /// <returns>The 'word'</returns>
-        private static ReadOnlySpan<char> GetNextWord(ReadOnlySpan<char> value, ref int pos)
+        private static ReadOnlySpan<char> GetNextWord(ReadOnlySpan<char> value, scoped ref int pos)
         {
             int? wordStart = null;
             for (int idx = pos; idx < value.Length; idx++)