Install numa package in rootfs #12144
Conversation
|
@ayakael FYI. I noticed that we don't install it in aports either: https://github.com/alpinelinux/aports/blob/4a065d2a45541825bbd6cf22653df2fc806f3ba3/community/dotnet7-build/APKBUILD. libnuma is a soft dependency: when available, use it otherwise use a fallback implementation. But in order to achieve that behavior, it has to be installed on the build machine. Otherwise, only the fallback code is compiled and then it would make no difference on .NET processes, if user choose to install It is better to add it to the build dependencies list. Then it is up to the consumer of dotnet package if they want to install numa package. |
Many thanks for the heads up. I'll include this with the |
|
@jkotas, PTAL. |
* Revert "Revert "Install numa package in rootfs (#12144)" (#12191)" This reverts commit 12b42d0. * Erase numactl-dev from Alpine 3.13 arm * Fix shellcheck warning about string replacement https://www.shellcheck.net/wiki/SC2001 * Add version check * Simplify
@ayakael, note that we have removed this dependency from .NET 8+ dotnet/runtime@de5a04b, so you can drop it when the newer version is prepared. It will tune to system's NUMA node configurations out-of-the-box. 🙂 |
|
@ayakael, just a reminder that we removed this dependency in .NET 8 so feel free to delete this line https://github.com/alpinelinux/aports/blob/12aaee3b2df187077ee3049db4f1399cbac1277e/community/dotnet8-runtime/APKBUILD#L86 🙂 |
Without this installed,
NUMASupportInitialize()on arm{64} platforms is skipping the initialization and directly going tofalsebranch: https://github.com/dotnet/runtime/blob/a10ee9ec8edaae541f074a77474cf6c2d1ffc56f/src/coreclr/gc/unix/gcenv.unix.cpp#L333 (HAVE_NUMA_His 0)