added common Fact and Theory attributes to Microsoft.DotNet.XUnitExtensions
#12313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akoeplinger
reviewed
Jan 27, 2023
src/Microsoft.DotNet.XUnitExtensions/src/Attributes/OsxOnlyFactAttribute.cs
Outdated
Show resolved
Hide resolved
…tNet.XUnitExtensions`
vlada-shubina
force-pushed
the
fact-theory-attributes
branch
from
bcb7b7b
to
601f789
Compare
akoeplinger
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: now with xunit/xunit#2073 it is possible to skip unit tests programmatically and this way works in VS, CI, etc.
There are common attributes that repos write usually based on platform and/or target framework, sometimes even more the once.
Microsoft.DotNet.XUnitExtensionslooks like the common extensions provide by arcade and will be a better place for it, so that all repos that use arcade can use it too.Repos that can benefit from it:
https://github.com/dotnet/sdk/blob/a30e465a2e2ea4e2550f319a2dc088daaafe5649/src/Tests/Microsoft.NET.TestFramework/Attributes/WindowsOnlyFactAttribute.cs
https://github.com/dotnet/installer/blob/8c476b58df6032c6713c69535d2679632abac9ba/test/Microsoft.DotNet.Tools.Tests.Utilities/WindowsOnlyFactAttribute.cs
https://github.com/dotnet/command-line-api/blob/72e86ec7615c0c8ecb6a13e34a5c0a97e9309909/src/System.CommandLine.Tests/Utility/WindowsOnlyFactAttribute.cs
TheoryandFactattributes msbuild#8348