Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add artifacts pattern to SDL tool arguments #13893

Merged
merged 3 commits into from
Jul 14, 2023

Conversation

MilenaHristova
Copy link
Member

Passing the path to the artifacts folder as a pattern suitable for BinSkim
We're enabling the BinSkim tool in the repos that run SDL checks in their CI builds as described in Automate BinSkim runs over official builds issue

To double check:

Copy link
Member

@riarenas riarenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is probably better added to the steps template directly.

eng/common/templates/job/execute-sdl.yml Outdated Show resolved Hide resolved
@riarenas riarenas dismissed their stale review July 12, 2023 16:45

I don't think I need to block on this comment.

@MilenaHristova
Copy link
Member Author

3rd try - making the artifacts directory into a pattern just for binskim. No additional arguments need to be passed from the yaml of the product repos.
Test run on arcade-services https://dev.azure.com/dnceng/internal/_build/results?buildId=2221107&view=results

@MilenaHristova MilenaHristova merged commit 8949dac into dotnet:main Jul 14, 2023
11 checks passed
@MilenaHristova MilenaHristova deleted the sdl-scan-artifacts branch July 14, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants