Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix encoding of common loc lss file #13992

Merged
merged 4 commits into from
Aug 22, 2023
Merged

Conversation

carlossanlop
Copy link
Member

@carlossanlop carlossanlop commented Aug 22, 2023

@cristianosuzuki77 @ViktorHofer @ericstj

This file was last flowed into dotnet/runtime by the dependency bot as a binary file. dotnet/runtime#90014

The file should be treated as plain text / xml.

The GitHub diff still thinks this extension is a binary file, but if you click on View File, it now looks like a plain text xml file, instead of showing monospaced characters to indicate it's binary. See before: https://github.com/dotnet/runtime/blob/a29a13b27ce9ee16b7dac4edede4994c433200ce/eng/common/loc/P22DotNetHtmlLocalization.lss

@ViktorHofer
Copy link
Member

Should we mark .lss files as plain text in this repo's .gitattributes file?

ViktorHofer
ViktorHofer previously approved these changes Aug 22, 2023
@carlossanlop
Copy link
Member Author

Should we mark .lss files as plain text in this repo's .gitattributes file?

Levi just mentioned the same to me. I'll fix that too.

@carlossanlop
Copy link
Member Author

@ViktorHofer Does that mean we need to make the same .gitattributes modification to all repos that inherit from arcade, or is that file also going to be flowed with dependency flow PRs?

@ViktorHofer
Copy link
Member

@ViktorHofer Does that mean we need to make the same .gitattributes modification to all repos that inherit from arcade, or is that file also going to be flowed with dependency flow PRs?

Ideally in all repos as the file doesn't flow into consuming repos. It's on a per repository basis. I think just having it in arcade and runtime for now should be sufficient. The origin (where it is originally checked in) is the most important place.

@ViktorHofer ViktorHofer enabled auto-merge (squash) August 22, 2023 18:43
@ViktorHofer ViktorHofer merged commit 4d9945d into dotnet:main Aug 22, 2023
@carlossanlop carlossanlop deleted the FixLocLss branch August 22, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants