Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 8.0 RTM #14099

Merged
merged 4 commits into from
Oct 10, 2023
Merged

Update to 8.0 RTM #14099

merged 4 commits into from
Oct 10, 2023

Conversation

ViktorHofer
Copy link
Member

Same as 858c011 for RC1

To double check:

Same as 858c011 for RC1
@ViktorHofer ViktorHofer self-assigned this Oct 10, 2023
@ViktorHofer
Copy link
Member Author

Interesting failure. Global tool restore is failing.

@mmitche
Copy link
Member

mmitche commented Oct 10, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@riarenas
Copy link
Member

Interesting failure. Global tool restore is failing.

This rings a bell, let me try and find it.

@riarenas
Copy link
Member

dotnet/aspnetcore#51059 is a PR where aspnetcore was trying to get tool restore to work with RC2. There are some known issues regarding that. They ended up skipping rc2 altogether.

dotnet/core#8799

@mmitche
Copy link
Member

mmitche commented Oct 10, 2023

I think we should skip to a newer RTM version then

@ViktorHofer
Copy link
Member Author

ViktorHofer commented Oct 10, 2023

Agreed this is a significant breaking change. Should we just skip to a recent unsigned SDK build then? Any preference on which version? The fix for that issue was merged in four days ago: dotnet/sdk#35884

@mmitche
Copy link
Member

mmitche commented Oct 10, 2023

Agreed this is a significant breaking change. Should we just skip to a recent unsigned SDK build then? Any preference on which version? The fix for that issue was merged in four days ago: dotnet/sdk#35884

I would go with latest. 8.0.100-rtm.23506.1. It should be signed and will have the fix. aspnetcore: 8.0.0-rtm.23502.22

@ViktorHofer ViktorHofer enabled auto-merge (squash) October 10, 2023 20:13
@ViktorHofer ViktorHofer merged commit f2fff4d into main Oct 10, 2023
15 checks passed
@mmitche
Copy link
Member

mmitche commented Oct 11, 2023

/backport to release/8.0

@github-actions
Copy link
Contributor

Started backporting to release/8.0: https://github.com/dotnet/arcade/actions/runs/6487190497

@ViktorHofer ViktorHofer deleted the ViktorHofer-patch-5 branch October 11, 2023 19:44
@ViktorHofer ViktorHofer changed the title Update to RC2 Update to 8.0 RTM Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants