Pin SRM & SCI versions for msbuild compatibility #14115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Desktop MSBuild ships with these versions of S.R.M and S.C.I. If we move forward, tasks won't be able to be loaded.
rainersigwald
previously approved these changes
Oct 12, 2023
|
I think you could solve the sourcebuild issue by making it conditional on .NET Framework vs .NET (core). |
which is available on SBRP
|
I decided to downgrade to 7.0.0 which is the version that's available on SBRP. @rainersigwald can you please re-approve (arcade policy). |
rainersigwald
approved these changes
Oct 12, 2023
|
@missymessa (as you filed #14047), those flaky test failures are really a productivity killer. Because of the test failures I had to retry and now need to wait another hour until the PR can be merged. Can we use build analysis here and make it possible to merge PRs with unrelated failures? I've been hitting this in 10+ different PRs in arcade in the last weeks. |
mmitche
approved these changes
Oct 12, 2023
This was referenced Oct 12, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/dnceng#1004
Desktop MSBuild ships with these versions of S.R.M and S.C.I. If we move forward, tasks won't be able to be loaded.
To double check: