Update xcopy-msbuild to buildtools 17.8.1 #14122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akoeplinger
approved these changes
Oct 14, 2023
riarenas
reviewed
Oct 16, 2023
| @@ -64,7 +64,7 @@ try { | |||
| $GlobalJson.tools | Add-Member -Name "vs" -Value (ConvertFrom-Json "{ `"version`": `"16.5`" }") -MemberType NoteProperty | |||
| } | |||
| if( -not ($GlobalJson.tools.PSObject.Properties.Name -match "xcopy-msbuild" )) { | |||
| $GlobalJson.tools | Add-Member -Name "xcopy-msbuild" -Value "17.7.2-1" -MemberType NoteProperty | |||
| $GlobalJson.tools | Add-Member -Name "xcopy-msbuild" -Value "17.8.1-2" -MemberType NoteProperty | |||
There was a problem hiding this comment.
What went wrong with 17.8.1 this time?
akoeplinger
pushed a commit
that referenced
this pull request
Oct 16, 2023
(cherry picked from commit ba607e9)
|
Backporting this to release/8.0 in #14110 |
|
Question: isn't this code path fundamentally flawed with this change? https://github.com/dotnet/arcade/blob/bb2b4326ddf03d86c92bd125dba87e9d8df63463/eng/common/tools.ps1#L445C20-L445C20 I can't see how xcopy-msbuild could automatically get picked up when specifying a higher version of VS than the minimum required one, i.e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/dnceng#997
To double check:
Because the failure is in the repo task (signing validation), it's actually pretty difficult to get a repro of this issue. You'd have to publish an updated private version of Arcade somewhere and then consume it in Arcade-validation and the last time I tried to generate a private version of Arcade for consumption, I gave up after 2 hours of fighting some signing problem. I was able to get a successful local repro and validate that this package should fix the issue. I'll keep an eye on Arcade and Arcade-validation post merge to ensure there are no resultant issues that need to be addressed.
Package was generated via https://dnceng-public.visualstudio.com/public/_build/results?buildId=438112&view=results. I'll submit a separate PR for those changes to the process.