Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable flakey test #14144

Closed

Conversation

garath
Copy link
Member

@garath garath commented Oct 19, 2023

Resolves #14054.

Related to #14047.

(Temporarily) disable flakey test ItCanBuildAManifestMsi that impacts customer productivity.

@garath garath self-assigned this Oct 19, 2023
@ViktorHofer
Copy link
Member

Looks like another test is flaky as well.

Copy link
Member

@joeloff joeloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a PR coming in that's going to address this. Is this blocking?

@missymessa
Copy link
Member

There's a PR coming in that's going to address this. Is this blocking?

Unfortunately, these flakey tests are preventing several Arcade PRs from being merged: https://dnceng-public.visualstudio.com/public/_build?definitionId=13

Copy link
Member

@missymessa missymessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM shipit

@joeloff
Copy link
Member

joeloff commented Oct 20, 2023

FYI, workload PR has been merged into main which should address the flaky test issues

@missymessa
Copy link
Member

@joeloff can you link the PR you're referencing?

@joeloff
Copy link
Member

joeloff commented Oct 20, 2023

@joeloff can you link the PR you're referencing?

#14083

@garath
Copy link
Member Author

garath commented Oct 24, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ViktorHofer
Copy link
Member

Looks like this PR isn't needed anymore

@garath
Copy link
Member Author

garath commented Oct 24, 2023

Looks like this PR isn't needed anymore

Oh, great! Thanks for highlighting that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable tests causing PRs with unrelated changes to fail
4 participants