Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize Oracle Linux #14595

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Conversation

Mr-Tao
Copy link
Contributor

@Mr-Tao Mr-Tao commented Mar 15, 2024

Copy link
Member

@tmds tmds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@tmds
Copy link
Member

tmds commented Mar 18, 2024

cc @elinor-fung @am11 @richlander

@am11
Copy link
Member

am11 commented Mar 18, 2024

I did my due diligence showing how we can avoid updating infrastructure code for this or any Linux distribution: dotnet/runtime#99728 (comment). If we still think this is the way to go, fine by me.

FWIW, this was the (quick) GitHub Action workflow https://github.com/am11/CrossRepoCITesting/actions/runs/8292219574/workflow. It created the release and uploaded the artifacts https://github.com/am11/CrossRepoCITesting/releases/tag/dotnet-ol.9.3-8292219574.

@tmds
Copy link
Member

tmds commented Mar 18, 2024

If we still think this is the way to go, fine by me.

Yes, I think we can add Oracle Linux with its RHEL and Rocky friends and treat them all the same. This PR is all the effort it takes.

A push towards towards using TargetRid by improving its visibility and UX gets a 👍 from me.
And that could be followed by removing all these cases.

@elinor-fung
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s), but failed to run 1 pipeline(s).

@elinor-fung elinor-fung merged commit bb4abc8 into dotnet:main Mar 26, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants