Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Update NuGet global packages cache detection" #14874

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Revert "Update NuGet global packages cache detection" #14874

merged 1 commit into from
Jun 20, 2024

Conversation

premun
Copy link
Member

@premun premun commented Jun 20, 2024

Reverts #14763

@premun
Copy link
Member Author

premun commented Jun 20, 2024

@sharwell we need to urgently flow arcade so I am reverting your changes until you have a fix

@premun premun enabled auto-merge (squash) June 20, 2024 10:36
@premun premun merged commit a1cd79a into main Jun 20, 2024
11 checks passed
@premun premun deleted the revert-14763-global-packages branch June 20, 2024 11:14
sharwell
sharwell reviewed Jun 20, 2024
View reviewed changes
src/Microsoft.DotNet.Arcade.Sdk/tools/RepoLayout.props
<!-- Respect environment variable for the NuGet Packages Root if set; otherwise, use the current default location -->
<NuGetPackageRoot Condition="'$(NuGetPackageRoot)' != ''">$([MSBuild]::NormalizeDirectory('$(NuGetPackageRoot)'))</NuGetPackageRoot>
<NuGetPackageRoot Condition="'$(NuGetPackageRoot)' == '' and '$(NUGET_PACKAGES)' != ''">$([MSBuild]::NormalizeDirectory('$(NUGET_PACKAGES)'))</NuGetPackageRoot>
<NuGetPackageRoot Condition="'$(NuGetPackageRoot)' == '' and '$(OS)' == 'Windows_NT'">$([MSBuild]::NormalizeDirectory('$(UserProfile)', '.nuget', 'packages'))</NuGetPackageRoot>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My system will not load any arcade-based code in Visual Studio or build any arcade-based repo from the command line with this invalid code in place.

@sharwell
Copy link
Member

@premun The fix was submitted yesterday in #14868, but I have no good way to validate it

@premun
Copy link
Member Author

premun commented Jun 20, 2024

@sharwell you can possibly:

  1. Build your Arcade branch locally, this will produce some 1.0.0-dev version of the packages somewhere in the artifacts/packages/ folder.
  2. Add the nuget folder to NuGet.config of your local arcade-validation
  3. Set the Arcade versions to 1.0.0-dev
  4. Now arcade-validation restores from your local folder
  5. Build and run the unit tests locally

@sharwell
Copy link
Member

@premun Can you clarify how to perform step (3)?

@premun
Copy link
Member Author

premun commented Jun 20, 2024

In arcade-validation, in eng/Versions.props or wherever (maybe Directory.Packages.props), make the repo depend on this local version.

sharwell added a commit to sharwell/arcade that referenced this pull request Jun 21, 2024
@sharwell
Reapply "Update NuGet global packages cache detection" (dotnet#14874)
cca5dbf 
This reverts commit a1cd79a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharwell sharwell sharwell left review comments

@pavel-purma pavel-purma pavel-purma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@premun @sharwell @pavel-purma