-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to use MSTest new features #14916
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow arcade users to rely on: - MSTest.Sdk - MSTest meta package - MSTest runner
Evangelink
commented
Jul 8, 2024
Evangelink
commented
Jul 8, 2024
@ViktorHofer @mmitche Could I get a review please? |
ViktorHofer
previously approved these changes
Jul 22, 2024
@ViktorHofer Updated to use booleans instead of enum |
ViktorHofer
approved these changes
Jul 22, 2024
mmitche
approved these changes
Jul 22, 2024
Evangelink
added a commit
that referenced
this pull request
Aug 9, 2024
# Conflicts: # src/Microsoft.DotNet.Arcade.Sdk/tools/MSTest/MSTest.targets
mmitche
pushed a commit
that referenced
this pull request
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow arcade users to rely on:
MSTest.Sdk
: current infra (before this change) always forces the installation of MSTest packages. This change allows to not install packages when user relies onMSTest.Sdk
while still allowing to onboard to MSTest runner.MSTest meta package: This meta package introduced in 2.2.10 ensures that versions are aligned and provides the recommended default experience for our users.
MSTest runner: Since 3.1, it's possible to use an alternative runner to VSTest.
To double check: