Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/8.0] Prepend ? when dealing with runtime query string prefixes #14945

Merged
merged 2 commits into from
Jul 17, 2024
Merged

[release/8.0] Prepend ? when dealing with runtime query string prefixes #14945

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc6fdbe
Prepend ? when dealing with runtime query string prefixes
mmitche Jul 16, 2024
a6f6354
Update DownloadFile.cs
mmitche Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Microsoft.DotNet.Arcade.Sdk/src/DownloadFile.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,12 @@ public override bool Execute()
{
var encodedTokenBytes = System.Convert.FromBase64String(encodedToken);
var decodedToken = System.Text.Encoding.UTF8.GetString(encodedTokenBytes);
// It's possible that the decoded SAS does not begin with the query string parameter.
// Handle cleanly before constructing the final URL
if (!decodedToken.StartsWith("?"))
{
decodedToken = $"?{decodedToken}";
}
uri = $"{uri}{decodedToken}";
}

Expand Down
Loading