[WIP] Use dotnet vstest runner instead of xunit.console #3333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViktorHofer
changed the title
ViktorHofer
force-pushed
the
VSTestRunner
branch
from
fc3d43d to
d02b956
Compare
ViktorHofer
changed the title
|
Remaining work:
|
ViktorHofer
force-pushed
the
VSTestRunner
branch
4 times, most recently
from
d95aadd to
f101b40
Compare
ViktorHofer
force-pushed
the
VSTestRunner
branch
from
f101b40 to
640103d
Compare
|
FYI: Not relevant for CoreFX, but definitely blocking Roslyn and other repos from using vstest: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1002535/ |
|
Thanks for letting me know :) |
|
Ported to runtime: dotnet/runtime@8790252 |
This was referenced Feb 1, 2020
This was referenced Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching from the unsupported xunit.console to dotnet test.
I had to bring the major version roll-forward policy back as the 3.0 SDK expects a 3.0 runtime to be present in the testhost folder. I don't know how to work around that until we have a 5.0 SDK and how to prevent that in future when we again switch the major version. Maybe we should coordinate the SDK branching with corefx/coreclr/core-setup more closely going forward.
Keeping the WIP marker until I validated all verticals and configurations in corefx. The consuming corefx branch to be cloned locally can be found here: https://github.com/ViktorHofer/corefx/tree/DotNetTest
cc @ericstj @safern @danmosemsft