Fix CrossDir directory creation order for Android #5003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@janvorli, @jkoritzinsky, please take a look. Thanks! |
jkoritzinsky
requested changes
Mar 9, 2020
There was a problem hiding this comment.
This file lives under eng/common, so the next change to it in Arcade will overwrite the file. Can you instead make a PR to update this file in the dotnet/arcade repo to ensure it propagates correctly throughout the repos?
Nevermind didn't realize this PR was in dotnet/arcade. That's on me. Ignore this comment (the sub comments are still relevant).
|
@janvorli, could this be merged? This is a bug fix, which we need for Android builds. |
|
@am11 I cannot merge it (the merge button is greyed out) as some required test legs have failed. I am trying to restart the legs now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #4915. These are some additional fixes which were identified during the build in docker.
I had a
.toolssymlink created before, which hid the fact that directory creation order was incorrect, where it tries to resolve the absolute path of__CrossDir.Also,
--subsetCategoryargument inruntime/build.shcurrently does not respect multiple components that were specified (no error or warning, it just builds the last subset). Therefore, the build instructions are updated with three commands.--progress=bar:force:noscrollto keep the progress on single line.