Delete RuntimeOS in favor of RuntimeInformation #5367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RuntimeOS calculation can be replaced with $([System.Runtime.InteropServices.RuntimeInformation]::RuntimeIdentifier so deleting the logic responsible for generating the file.
eerhardt
approved these changes
Apr 28, 2020
There was a problem hiding this comment.
Looks great to me.
I wouldn't merge this until your dotnet/runtime#35538 changes goes in though.
Anipik
approved these changes
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RuntimeOS calculation can be replaced with
$([System.Runtime.InteropServices.RuntimeInformation]::RuntimeIdentifier)so deleting the logic responsible for generating the RuntimeOS props file.dotnet/runtime#35538 is removing the usage of this target.
cc @eerhardt