Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use helix reporting #7383

Merged
merged 18 commits into from
Jul 1, 2021
Merged

Use helix reporting #7383

merged 18 commits into from
Jul 1, 2021

Conversation

ChadNedzlek
Copy link
Member

@ChadNedzlek ChadNedzlek commented May 12, 2021

Use the Helix test reporting feature that allows for test retry configuration/reporting.

@dotnet dotnet deleted a comment from azure-pipelines bot May 20, 2021
@dotnet dotnet deleted a comment from azure-pipelines bot May 20, 2021
@dotnet dotnet deleted a comment from azure-pipelines bot May 20, 2021
@dotnet dotnet deleted a comment from azure-pipelines bot May 20, 2021
@dotnet dotnet deleted a comment from azure-pipelines bot May 20, 2021
# Conflicts:
#	src/Microsoft.DotNet.Helix/Sdk/tools/azure-pipelines/reporter/run.py
@dotnet dotnet deleted a comment from azure-pipelines bot May 21, 2021
@dotnet dotnet deleted a comment from azure-pipelines bot May 21, 2021
@dotnet dotnet deleted a comment from azure-pipelines bot May 21, 2021
@dotnet dotnet deleted a comment from azure-pipelines bot May 21, 2021
@dotnet dotnet deleted a comment from azure-pipelines bot May 21, 2021
@dotnet dotnet deleted a comment from azure-pipelines bot May 24, 2021
@dotnet dotnet deleted a comment from azure-pipelines bot May 25, 2021
@dotnet dotnet deleted a comment from azure-pipelines bot May 26, 2021
@dotnet dotnet deleted a comment from azure-pipelines bot May 26, 2021
@dotnet dotnet deleted a comment from azure-pipelines bot May 26, 2021
# Conflicts:
#	src/Microsoft.DotNet.Helix/Sdk/tools/azure-pipelines/reporter/run.py
@dotnet dotnet deleted a comment from azure-pipelines bot Jun 25, 2021
@missymessa
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@missymessa
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MattGal
Copy link
Member

MattGal commented Jun 29, 2021

It would be very beneficial with this reporting change to add support for a docker-container helix work item (just a row in UnitTests.proj), so we find out whether this works there before going to production.

@missymessa
Copy link
Member

It would be very beneficial with this reporting change to add support for a docker-container helix work item (just a row in UnitTests.proj), so we find out whether this works there before going to production.

@MattGal would you mind writing an issue for this work? Since Chad is OOF for another week, we are likely going to merge this PR in as-is before he gets back if it's successful.

@missymessa
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MattGal
Copy link
Member

MattGal commented Jul 1, 2021

It would be very beneficial with this reporting change to add support for a docker-container helix work item (just a row in UnitTests.proj), so we find out whether this works there before going to production.

@MattGal would you mind writing an issue for this work? Since Chad is OOF for another week, we are likely going to merge this PR in as-is before he gets back if it's successful.

It's just one line to the project file to prove that this scenario works, I really think either adding it or some proof of manually exercising this with it should be part of this PR before it merges. If you get everything else working but that's still a problem, I can help.

@missymessa
Copy link
Member

It would be very beneficial with this reporting change to add support for a docker-container helix work item (just a row in UnitTests.proj), so we find out whether this works there before going to production.

@MattGal would you mind writing an issue for this work? Since Chad is OOF for another week, we are likely going to merge this PR in as-is before he gets back if it's successful.

It's just one line to the project file to prove that this scenario works, I really think either adding it or some proof of manually exercising this with it should be part of this PR before it merges. If you get everything else working but that's still a problem, I can help.

Would you mind contributing that change to this PR?

@MattGal
Copy link
Member

MattGal commented Jul 1, 2021

Would you mind contributing that change to this PR?

Sure, but let's wait til the normal path is green in the current run to make sure we're not mixing and matching different problems.

Copy link
Member

@MattGal MattGal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will open a PR immediately after this merges to add the docker testing I commented about.

@missymessa
Copy link
Member

LGTM shipit

@missymessa missymessa merged commit 7f52af2 into dotnet:main Jul 1, 2021
MattGal added a commit that referenced this pull request Jul 1, 2021
Follow up from #7383.  This means we now depend on the Helix clients to do reporting, and the code path is somewhat different for Docker, so let's test one docker variation (Alpine chosen because it's small, and the original reason the Helix Docker feature exists)
missymessa added a commit that referenced this pull request Jul 7, 2021
@missymessa missymessa mentioned this pull request Jul 7, 2021
1 task
missymessa added a commit that referenced this pull request Jul 7, 2021
* Update badge branch names

* Revert "Use helix reporting (#7383)"

This reverts commit 7f52af2.
@ChadNedzlek ChadNedzlek mentioned this pull request Jul 19, 2021
ChadNedzlek added a commit that referenced this pull request Aug 10, 2021
Reintroduce corrected #7383

This switches arcade from using a custom reporter, to using a reporter more tightly integrated with helix. That reporter has the capacity to handle local test retrying and reporting to Azure DevOps for "flaky" tests.

To enable the retry, a file "eng/test-configuration.json" must be created following the documented schema.
MattGal added a commit that referenced this pull request Aug 25, 2021
… This means we now depend on the Helix clients to do reporting, and the code path is somewhat different for Docker, so let's test one docker variation
MattGal added a commit that referenced this pull request Aug 25, 2021
… This means we now depend on the Helix clients to do reporting, and the code path is somewhat different for Docker, so let's test one docker variation (#7790)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants