Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we test on TFMs that have unique RID-specific assets #7470

Merged
merged 1 commit into from
Jun 5, 2021

Conversation

ericstj
Copy link
Member

@ericstj ericstj commented Jun 4, 2021

@ViktorHofer ViktorHofer merged commit 582981c into dotnet:main Jun 5, 2021
@ViktorHofer
Copy link
Member

Nit: Isn't the rid part now dead code?

@ericstj
Copy link
Member Author

ericstj commented Jun 5, 2021

RID part is not dead yet, not until I merge my PR. This is needed regardless because it makes sure we test frameworks that will have RID-specific runtime targets. I noticed that when testing my PR.

Once my PR is merged to runtime we can delete the RID part of this.

@ViktorHofer
Copy link
Member

Works for me 👍

@Anipik
Copy link
Contributor

Anipik commented Jun 7, 2021

i have a pr in pipeline which remodels everything, i can delete the rid as part of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants