Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating xunit package version on dotnet/arcade #7911

Merged
merged 12 commits into from
Sep 29, 2021
Merged

Updating xunit package version on dotnet/arcade #7911

merged 12 commits into from
Sep 29, 2021

Conversation

maryamariyan
Copy link
Member

Similar to PR dotnet/runtime#59275 for dotnet/runtime, updating xunit package version on arcade here.

@maryamariyan maryamariyan requested a review from a team September 17, 2021 19:08
maryamariyan
maryamariyan commented Sep 17, 2021
View reviewed changes
eng/Versions.props
<XUnitAbstractionsVersion>2.0.3</XUnitAbstractionsVersion>
<XUnitVSRunnerVersion>2.4.1</XUnitVSRunnerVersion>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is not used anywhere, so removing

@maryamariyan maryamariyan mentioned this pull request Sep 17, 2021
Merged
@ericstj
Copy link
Member

ericstj commented Sep 17, 2021

CI shows these errors:
https://dev.azure.com/dnceng/public/_build/results?buildId=1369135&view=ms.vss-test-web.build-test-results-tab&runId=39971846&resultId=100003&paneView=dotnet-dnceng.dnceng-build-release-tasks.helix-test-information-tab

Errors
DownloadError: Unable to download https://api.nuget.org/v3-flatcontainer/xunit.runner.console/2.4.2-pre.9/xunit.runner.console.2.4.2-pre.9.nupkg after retrying. Execution may fail as a result.
DownloadError: Unable to download https://api.nuget.org/v3-flatcontainer/xunit.runner.console/2.4.2-pre.9/xunit.runner.console.2.4.2-pre.9.nupkg after retrying. Execution may fail as a result.

Something is trying to construct a path to nuget to fetch test packages.

@safern
Copy link
Member

safern commented Sep 20, 2021

This is what is constructing that path:

arcade/src/Microsoft.DotNet.Helix/Sdk/tools/xunit-runner/XUnitRunner.targets

Line 15 in e7ede87

<Uri>https://api.nuget.org/v3-flatcontainer/xunit.runner.console/$(XUnitRunnerVersion)/xunit.runner.console.$(XUnitRunnerVersion).nupkg</Uri>

@maryamariyan
Copy link
Member Author

This is what is constructing that path

my last commit hardcodes it to 2.4.1 f8d6df0

@ericstj
Copy link
Member

ericstj commented Sep 21, 2021

my last commit hardcodes it to 2.4.1 f8d6df0

Why wouldn't we point it at a download link from https://dev.azure.com/dnceng/public/_packaging?_a=package&feed=dotnet-eng&package=xunit.runner.console&protocolType=NuGet&version=2.4.2-pre.9?

@ericstj ericstj enabled auto-merge (squash) September 24, 2021 19:01
@ericstj
Copy link
Member

ericstj commented Sep 27, 2021

Test logs still show https://dev.azure.com/dnceng/public/_build/results?buildId=1388150&view=ms.vss-test-web.build-test-results-tab&runId=40405972&resultId=100020&paneView=debug

DownloadError: Unable to download https://dev.azure.com/dnceng/public/_packaging after retrying. Execution may fail as a result.
DownloadError: Unable to download https://dev.azure.com/dnceng/public/_packaging after retrying. Execution may fail as a result

Is that the actual download URL? The link I shared was just to the gallery page.

@maryamariyan @ericstj
Update src/Microsoft.DotNet.Helix/Sdk/tools/xunit-runner/XUnitRunner.…
06868dd 
…targets

Co-authored-by: Eric StJohn <ericstj@microsoft.com>
@ericstj ericstj merged commit 9a94c6b into dotnet:main Sep 29, 2021
@RussKie
Copy link
Member

RussKie commented Oct 11, 2021 •
edited
Loading

This change is causing Windows Forms builds to fail: dotnet/winforms#5934

Please be mindful that Arcade is a shared library, and check with all consumers when making such changes. Thank you.

@RussKie RussKie mentioned this pull request Oct 11, 2021
Merged
RussKie added a commit to dotnet/winforms that referenced this pull request Oct 11, 2021
@RussKie
Bump xunit version
378f6a4 
Relates to dotnet/arcade#7911
@ericstj
Copy link
Member

ericstj commented Oct 12, 2021 •
edited
Loading

Sure we can notify more folks when we upgrade this dependency in the future. FWIW we aren't expecting these version updates to be breaking (in fact, we're flighting them to find real breaks and then working with xUnit to avoid those).

Question for you: does WinForms need to define the version here? Can they just rely on Arcade defining the version. That way they wouldn't end up downgrading the dependency.

@RussKie
Copy link
Member

RussKie commented Oct 18, 2021

Here's the build log:

D:\Development\dotnet-winforms\src\System.Windows.Forms.Primitives\tests\UnitTests\System.Windows.Forms.Primitives.Tests.csproj : error NU1107: Version conflict detected for xunit.extensibility.core. Install/reference xunit.extensibility.core 2.4.2-pre.9 directly to project System.Windows.Forms.Primitives.Tests to resolve this issue.  [D:\Development\dotnet-winforms\Winforms.sln]
D:\Development\dotnet-winforms\src\System.Windows.Forms.Primitives\tests\UnitTests\System.Windows.Forms.Primitives.Tests.csproj : error NU1107:  System.Windows.Forms.Primitives.Tests -> System.Windows.Forms.Primitives.TestUtilities -> Microsoft.DotNet.XUnitExtensions 6.0.0-beta.21513.3 -> xunit.extensibility.core (>= 2.4.2-pre.9)  [D:\Development\dotnet-winforms\Winforms.sln]
D:\Development\dotnet-winforms\src\System.Windows.Forms.Primitives\tests\UnitTests\System.Windows.Forms.Primitives.Tests.csproj : error NU1107:  System.Windows.Forms.Primitives.Tests -> xunit 2.4.1 -> xunit.core 2.4.1 -> xunit.extensibility.core (= 2.4.1). [D:\Development\dotnet-winforms\Winforms.sln]
D:\Development\dotnet-winforms\src\Microsoft.VisualBasic.Forms\tests\UnitTests\Microsoft.VisualBasic.Forms.Tests.vbproj : error NU1107: Version conflict detected for xunit.extensibility.core. Install/reference xunit.extensibility.core 2.4.2-pre.9 directly to project Microsoft.VisualBasic.Forms.Tests to resolve this issue.  [D:\Development\dotnet-winforms\Winforms.sln]
D:\Development\dotnet-winforms\src\Microsoft.VisualBasic.Forms\tests\UnitTests\Microsoft.VisualBasic.Forms.Tests.vbproj : error NU1107:  Microsoft.VisualBasic.Forms.Tests -> System.Windows.Forms.TestUtilities -> Microsoft.DotNet.XUnitExtensions 6.0.0-beta.21513.3 -> xunit.extensibility.core (>= 2.4.2-pre.9)  [D:\Development\dotnet-winforms\Winforms.sln]
D:\Development\dotnet-winforms\src\Microsoft.VisualBasic.Forms\tests\UnitTests\Microsoft.VisualBasic.Forms.Tests.vbproj : error NU1107:  Microsoft.VisualBasic.Forms.Tests -> xunit 2.4.1 -> xunit.core 2.4.1 -> xunit.extensibility.core (= 2.4.1). [D:\Development\dotnet-winforms\Winforms.sln]
D:\Development\dotnet-winforms\src\Microsoft.VisualBasic\tests\UnitTests\Microsoft.VisualBasic.Tests.csproj : error NU1107: Version conflict detected for xunit.extensibility.core. Install/reference xunit.extensibility.core 2.4.2-pre.9 directly to project Microsoft.VisualBasic.Tests to resolve this issue.  [D:\Development\dotnet-winforms\Winforms.sln]
D:\Development\dotnet-winforms\src\Microsoft.VisualBasic\tests\UnitTests\Microsoft.VisualBasic.Tests.csproj : error NU1107:  Microsoft.VisualBasic.Tests -> Microsoft.DotNet.XUnitExtensions 6.0.0-beta.21513.3 -> xunit.extensibility.core (>= 2.4.2-pre.9)  [D:\Development\dotnet-winforms\Winforms.sln]
D:\Development\dotnet-winforms\src\Microsoft.VisualBasic\tests\UnitTests\Microsoft.VisualBasic.Tests.csproj : error NU1107:  Microsoft.VisualBasic.Tests -> xunit 2.4.1 -> xunit.core 2.4.1 -> xunit.extensibility.core (= 2.4.1). [D:\Development\dotnet-winforms\Winforms.sln]
D:\Development\dotnet-winforms\src\System.Windows.Forms.Primitives\tests\TestUtilities.Tests\System.Windows.Forms.Primitives.TestUtilities.Tests.csproj : error NU1107: Version conflict detected for xunit.extensibility.core. Install/reference xunit.extensibility.core 2.4.2-pre.9 directly to project System.Windows.Forms.Primitives.TestUtilities.Tests to resolve this issue.  [D:\Development\dotnet-winforms\Winforms.sln]
D:\Development\dotnet-winforms\src\System.Windows.Forms.Primitives\tests\TestUtilities.Tests\System.Windows.Forms.Primitives.TestUtilities.Tests.csproj : error NU1107:  System.Windows.Forms.Primitives.TestUtilities.Tests -> System.Windows.Forms.Primitives.TestUtilities -> Microsoft.DotNet.XUnitExtensions 6.0.0-beta.21513.3 -> xunit.extensibility.core (>= 2.4.2-pre.9)  [D:\Development\dotnet-winforms\Winforms.sln]
D:\Development\dotnet-winforms\src\System.Windows.Forms.Primitives\tests\TestUtilities.Tests\System.Windows.Forms.Primitives.TestUtilities.Tests.csproj : error NU1107:  System.Windows.Forms.Primitives.TestUtilities.Tests -> xunit 2.4.1 -> xunit.core 2.4.1 -> xunit.extensibility.core (= 2.4.1). [D:\Development\dotnet-winforms\Winforms.sln]
D:\Development\dotnet-winforms\src\System.Windows.Forms\tests\UnitTests\System.Windows.Forms.Tests.csproj : error NU1107: Version conflict detected for xunit.extensibility.core. Install/reference xunit.extensibility.core 2.4.2-pre.9 directly to project System.Windows.Forms.Tests to resolve this issue.  [D:\Development\dotnet-winforms\Winforms.sln]
D:\Development\dotnet-winforms\src\System.Windows.Forms\tests\UnitTests\System.Windows.Forms.Tests.csproj : error NU1107:  System.Windows.Forms.Tests -> System.Windows.Forms.TestUtilities -> Microsoft.DotNet.XUnitExtensions 6.0.0-beta.21513.3 -> xunit.extensibility.core (>= 2.4.2-pre.9)  [D:\Development\dotnet-winforms\Winforms.sln]
D:\Development\dotnet-winforms\src\System.Windows.Forms\tests\UnitTests\System.Windows.Forms.Tests.csproj : error NU1107:  System.Windows.Forms.Tests -> xunit 2.4.1 -> xunit.core 2.4.1 -> xunit.extensibility.core (= 2.4.1). [D:\Development\dotnet-winforms\Winforms.sln]
D:\Development\dotnet-winforms\src\System.Windows.Forms.Analyzers\tests\UnitTests\System.Windows.Forms.Analyzers.Tests.csproj : error NU1107: Version conflict detected for xunit.extensibility.core. Install/reference xunit.extensibility.core 2.4.2-pre.9 directly to project System.Windows.Forms.Analyzers.Tests to resolve this issue.  [D:\Development\dotnet-winforms\Winforms.sln]
D:\Development\dotnet-winforms\src\System.Windows.Forms.Analyzers\tests\UnitTests\System.Windows.Forms.Analyzers.Tests.csproj : error NU1107:  System.Windows.Forms.Analyzers.Tests -> System.Windows.Forms.Common.TestUtilities -> Microsoft.DotNet.XUnitExtensions 6.0.0-beta.21513.3 -> xunit.extensibility.core (>= 2.4.2-pre.9)  [D:\Development\dotnet-winforms\Winforms.sln]
D:\Development\dotnet-winforms\src\System.Windows.Forms.Analyzers\tests\UnitTests\System.Windows.Forms.Analyzers.Tests.csproj : error NU1107:  System.Windows.Forms.Analyzers.Tests -> xunit 2.4.1 -> xunit.core 2.4.1 -> xunit.extensibility.core (= 2.4.1). [D:\Development\dotnet-winforms\Winforms.sln]
D:\Development\dotnet-winforms\src\System.Windows.Forms.Design\tests\UnitTests\System.Windows.Forms.Design.Tests.csproj : error NU1107: Version conflict detected for xunit.extensibility.core. Install/reference xunit.extensibility.core 2.4.2-pre.9 directly to project System.Windows.Forms.Design.Tests to resolve this issue.  [D:\Development\dotnet-winforms\Winforms.sln]
D:\Development\dotnet-winforms\src\System.Windows.Forms.Design\tests\UnitTests\System.Windows.Forms.Design.Tests.csproj : error NU1107:  System.Windows.Forms.Design.Tests -> System.Windows.Forms.TestUtilities -> Microsoft.DotNet.XUnitExtensions 6.0.0-beta.21513.3 -> xunit.extensibility.core (>= 2.4.2-pre.9)  [D:\Development\dotnet-winforms\Winforms.sln]
D:\Development\dotnet-winforms\src\System.Windows.Forms.Design\tests\UnitTests\System.Windows.Forms.Design.Tests.csproj : error NU1107:  System.Windows.Forms.Design.Tests -> xunit 2.4.1 -> xunit.core 2.4.1 -> xunit.extensibility.core (= 2.4.1). [D:\Development\dotnet-winforms\Winforms.sln]
D:\Development\dotnet-winforms\src\Common\tests\TestUtilities\System.Windows.Forms.Common.TestUtilities.csproj : error NU1605: Detected package downgrade: xunit.assert from 2.4.2-pre.9 to 2.4.1. Reference the package directly from the project to select a different version.  [D:\Development\dotnet-winforms\Winforms.sln]
D:\Development\dotnet-winforms\src\Common\tests\TestUtilities\System.Windows.Forms.Common.TestUtilities.csproj : error NU1605:  System.Windows.Forms.Common.TestUtilities -> Microsoft.DotNet.RemoteExecutor 6.0.0-beta.21513.3 -> xunit.assert (>= 2.4.2-pre.9)  [D:\Development\dotnet-winforms\Winforms.sln]
D:\Development\dotnet-winforms\src\Common\tests\TestUtilities\System.Windows.Forms.Common.TestUtilities.csproj : error NU1605:  System.Windows.Forms.Common.TestUtilities -> xunit.assert (>= 2.4.1) [D:\Development\dotnet-winforms\Winforms.sln]
D:\Development\dotnet-winforms\src\System.Windows.Forms\tests\TestUtilities\System.Windows.Forms.TestUtilities.csproj : error NU1605: Detected package downgrade: xunit.assert from 2.4.2-pre.9 to 2.4.1. Reference the package directly from the project to select a different version.  [D:\Development\dotnet-winforms\Winforms.sln]
D:\Development\dotnet-winforms\src\System.Windows.Forms\tests\TestUtilities\System.Windows.Forms.TestUtilities.csproj : error NU1605:  System.Windows.Forms.TestUtilities -> Microsoft.DotNet.RemoteExecutor 6.0.0-beta.21513.3 -> xunit.assert (>= 2.4.2-pre.9)  [D:\Development\dotnet-winforms\Winforms.sln]
D:\Development\dotnet-winforms\src\System.Windows.Forms\tests\TestUtilities\System.Windows.Forms.TestUtilities.csproj : error NU1605:  System.Windows.Forms.TestUtilities -> xunit.assert (>= 2.4.1) [D:\Development\dotnet-winforms\Winforms.sln]
D:\Development\dotnet-winforms\src\System.Windows.Forms\tests\InteropTests\System.Windows.Forms.Interop.Tests.csproj : error NU1107: Version conflict detected for xunit.extensibility.core. Install/reference xunit.extensibility.core 2.4.2-pre.9 directly to project System.Windows.Forms.Interop.Tests to resolve this issue.  [D:\Development\dotnet-winforms\Winforms.sln]
D:\Development\dotnet-winforms\src\System.Windows.Forms\tests\InteropTests\System.Windows.Forms.Interop.Tests.csproj : error NU1107:  System.Windows.Forms.Interop.Tests -> System.Windows.Forms.TestUtilities -> Microsoft.DotNet.XUnitExtensions 6.0.0-beta.21513.3 -> xunit.extensibility.core (>= 2.4.2-pre.9)  [D:\Development\dotnet-winforms\Winforms.sln]
D:\Development\dotnet-winforms\src\System.Windows.Forms\tests\InteropTests\System.Windows.Forms.Interop.Tests.csproj : error NU1107:  System.Windows.Forms.Interop.Tests -> xunit 2.4.1 -> xunit.core 2.4.1 -> xunit.extensibility.core (= 2.4.1). [D:\Development\dotnet-winforms\Winforms.sln]
D:\Development\dotnet-winforms\src\System.Windows.Forms.Primitives\tests\TestUtilities\System.Windows.Forms.Primitives.TestUtilities.csproj : error NU1605: Detected package downgrade: xunit.assert from 2.4.2-pre.9 to 2.4.1. Reference the package directly from the project to select a different version.  [D:\Development\dotnet-winforms\Winforms.sln]
D:\Development\dotnet-winforms\src\System.Windows.Forms.Primitives\tests\TestUtilities\System.Windows.Forms.Primitives.TestUtilities.csproj : error NU1605:  System.Windows.Forms.Primitives.TestUtilities -> System.Windows.Forms.Common.TestUtilities -> Microsoft.DotNet.RemoteExecutor 6.0.0-beta.21513.3 -> xunit.assert (>= 2.4.2-pre.9)  [D:\Development\dotnet-winforms\Winforms.sln]
D:\Development\dotnet-winforms\src\System.Windows.Forms.Primitives\tests\TestUtilities\System.Windows.Forms.Primitives.TestUtilities.csproj : error NU1605:  System.Windows.Forms.Primitives.TestUtilities -> xunit.assert (>= 2.4.1) [D:\Development\dotnet-winforms\Winforms.sln]
D:\Development\dotnet-winforms\src\System.Windows.Forms.Analyzers.CSharp\tests\UnitTests\System.Windows.Forms.Analyzers.CSharp.Tests.csproj : error NU1107: Version conflict detected for xunit.extensibility.core. Install/reference xunit.extensibility.core 2.4.2-pre.9 directly to project System.Windows.Forms.Analyzers.CSharp.Tests to resolve this issue.  [D:\Development\dotnet-winforms\Winforms.sln]
D:\Development\dotnet-winforms\src\System.Windows.Forms.Analyzers.CSharp\tests\UnitTests\System.Windows.Forms.Analyzers.CSharp.Tests.csproj : error NU1107:  System.Windows.Forms.Analyzers.CSharp.Tests -> System.Windows.Forms.Common.TestUtilities -> Microsoft.DotNet.XUnitExtensions 6.0.0-beta.21513.3 -> xunit.extensibility.core (>= 2.4.2-pre.9)  [D:\Development\dotnet-winforms\Winforms.sln]
D:\Development\dotnet-winforms\src\System.Windows.Forms.Analyzers.CSharp\tests\UnitTests\System.Windows.Forms.Analyzers.CSharp.Tests.csproj : error NU1107:  System.Windows.Forms.Analyzers.CSharp.Tests -> xunit 2.4.1 -> xunit.core 2.4.1 -> xunit.extensibility.core (= 2.4.1). [D:\Development\dotnet-winforms\Winforms.sln]

Looking through it and the projects references I'm having difficulties determining what is actually causing the version mismatch.

External packages (e.g. Xunit.StaFact or Verify.Xunit) according to nuget.org target xUnit >= 2.4.1...

Do you have a suggestion on how to determine the cause?

P.S. looks like a number of our packages are out-dated, and that's something we'll need to do but we'd be good to root out the problem first.
/cc: @dreddy-work

@danmoseley danmoseley mentioned this pull request Feb 7, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericstj ericstj ericstj approved these changes

@safern safern safern approved these changes

@Anipik Anipik Anipik approved these changes

@ViktorHofer ViktorHofer ViktorHofer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@maryamariyan @ericstj @safern @RussKie @ViktorHofer @Anipik