Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't output stdout from lld check in init-compiler.sh #8221

Merged
merged 2 commits into from
Nov 26, 2021
Merged

Don't output stdout from lld check in init-compiler.sh #8221

merged 2 commits into from
Nov 26, 2021

Commits on Nov 26, 2021

  1. Don't output stdout from lld check 

    This caused an issue in dotnet/runtime#61668 because https://github.com/dotnet/runtime/blob/c00b06826ca4d333ef69d51e523ef7bd309b8631/src/libraries/System.Runtime.InteropServices/tests/TestAssets/NativeExports/NativeExports.csproj#L33 sources the init-compiler.sh and uses the stdout from it and we were outputting the stdout of the lld check which broke this.

Before:

```
# bash -c 'source "eng/common/native/init-compiler.sh" "eng/common/native/" x64 clang && echo $CC'
LLD 10.0.1 (compatible with GNU linkers)
/usr/bin/clang-10
```

After:

```
# bash -c 'source "eng/common/native/init-compiler.sh" "eng/common/native/" x64 clang && echo $CC'
/usr/bin/clang-10
```
    @akoeplinger
    akoeplinger committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    50014ff View commit details
    Browse the repository at this point in the history

  2. Add note about stdout

    @akoeplinger
    akoeplinger committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    b1f0241 View commit details
    Browse the repository at this point in the history