Fix TargetFramework package via multiTargeting and binplace import #8421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The package's props and targets files need to be imported in both the outer and the inner build. Hence, adding a buildMultiTargeting folder that redirects to the build folder.
ViktorHofer
changed the title
|
@akoeplinger in case you're already working, could you please approve this PR for me so that I don't have to wait until Redmond folks are up? 🙏 |
akoeplinger
approved these changes
Feb 2, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renaming and migrating the package from an msbuild sdk package to a normal nuget package broke the imports and the evaluation order which I'm fixing with this PR. Tested the change locally.
The package's props and targets files need to be imported in both the outer and the inner build. Hence, adding a buildMultiTargeting folder that redirects to the build folder.
Also the
EnableBinPlaceproperty is now evaluated sooner than expected and hence some properties in dotnet/runtime aren't yet set which this property depends on. Inline the condition into the target so that it runs later and condition the overall import of the BinPlace.targets file via the existing condition.To double check: