-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tsaconfig to enable compliance tooling #358
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmoseley
added
the
NO-MERGE
The PR is not ready for merge yet (see discussion for detailed reasons)
label
Jul 11, 2024
OK @mmitche this is now correct, even though this isn't arcade, right? |
Although, perhaps we should wait to figure this out: dotnet/aspire#4860 (comment) |
danmoseley
removed
the
NO-MERGE
The PR is not ready for merge yet (see discussion for detailed reasons)
label
Jul 20, 2024
|
You enabled the 1ESPT compliance tooling, so yes it should work. |
mmitche
approved these changes
Jul 22, 2024
meneasysoft
pushed a commit
to meneasysoft/aspire-samples
that referenced
this pull request
Jul 25, 2024
* tsaconfig * tsaconfig * new way * Update azure-pipelines.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy dotnet/extensions#5285
@mmitche I believe aspire-samples needs to have compliance tools run as we're treating it as prod. BUT it doesn't use arcade. Will this still trigger the tooling we want?