Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Semantic logs don't show exceptions #173

Closed
davidfowl opened this issue Oct 1, 2023 · 6 comments · Fixed by #373
Closed

Semantic logs don't show exceptions #173

davidfowl opened this issue Oct 1, 2023 · 6 comments · Fixed by #373
Assignees
@davidfowl
Labels
area-telemetry
Milestone
preview 1 (.NET 8...

Comments

@davidfowl
Copy link
Member

They seem to be missing

image
@JamesNK
Copy link
Member

JamesNK commented Oct 2, 2023

It looks like OTEL has intentionally disabled sending exceptions and some other .NET-specific data:

https://github.com/open-telemetry/opentelemetry-dotnet/blob/23b041c5539fdce770c40acc702de2a106a0de63/src/OpenTelemetry.Exporter.OpenTelemetryProtocol/Implementation/LogRecordExtensions.cs#L81-L114

@danmoseley danmoseley transferred this issue from another repository Oct 9, 2023
@dbreshears dbreshears modified the milestones: some time after preview, preview-3 weeks Oct 10, 2023
@dbreshears
Copy link
Contributor

External - There will be work in the dashboard once fixed and update to latest OpenTelemetry. Need to ask when the next release is.

@JamesNK
Copy link
Member

JamesNK commented Oct 11, 2023

Requires open-telemetry/opentelemetry-dotnet#4892

Reaction in Aspire: Update OTEL version when available, pass environment variable.

@danmoseley
Copy link
Member

waiting on preview release -- need this week in order to react.

cc @samsp-msft

@davidfowl
Copy link
Member Author

davidfowl commented Oct 17, 2023 •
edited
Loading

We have a release!

https://www.nuget.org/packages/OpenTelemetry.Exporter.OpenTelemetryProtocol/1.7.0-alpha.1

https://github.com/open-telemetry/opentelemetry-dotnet/releases/tag/core-1.7.0-alpha.1

I'm going to try this out.

@davidfowl
Copy link
Member Author

I setup these packages to be mirrored

@davidfowl davidfowl assigned davidfowl and unassigned JamesNK Oct 18, 2023
davidfowl added a commit that referenced this issue Oct 18, 2023
@davidfowl
Update to the 1.7.0-alpha release of otel
822927c 
- This adds 2 experimental flags to for projects to enable the semantic conventions for event ids and exceptions

Fixes #173
@davidfowl davidfowl mentioned this issue Oct 18, 2023
Merged
davidfowl added a commit that referenced this issue Oct 18, 2023
@davidfowl
Update to the 1.7.0-alpha release of otel (#373)
37207ea 
* Update to the 1.7.0-alpha release of otel
- This adds 2 experimental flags to for projects to enable the semantic conventions for event ids and exceptions

Fixes #173

* Updated the otel in memory exporter to make tests pass
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@davidfowl davidfowl

Labels
area-telemetry
Projects
None yet
Milestone
preview 1 (.NET 8 GA)
Development

Successfully merging a pull request may close this issue.

Update to the 1.7.0-alpha release of otel dotnet/aspire
5 participants
@davidfowl @JamesNK @dbreshears @danmoseley @tlmii