Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auth for dashboard web app and resource service client #3033
Auth for dashboard web app and resource service client #3033
Changes from 5 commits
d1baf4c
635d7d3
669476f
0925379
f2ab58c
28ae241
eb33c92
d1a9f45
8f3e578
e31b650
efdfab9
1db68e4
07d6e9a
25b4ddf
0d41cfb
ab393f4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may wish to have a
RemoteCertificateValidationCallback
here that validates the server certificate's thumbprint (and corresponding config to pass that cert in).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine for now but I'd like to see if we have move this auth configuration to
Dashboard:Frontend:OpenIdConnect
. I think we can do that by binding another config section.Can happen in a future PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Authentication:Schemes:<schemename>
seems to be the de facto way of doing this, no? If we move to our own config container, I'd be concerned we miss out on other built-in configuration controls.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Schemes include functionality to bind their options to a convention-based location in
IConfiguration
. It's 1 line of code to add support for binding to an extra location.I don't know yet whether we want to do this. If there are sacrifices, then it might be left at the default location.