Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update container runtime not found exception message #3224

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

DamianEdwards
Copy link
Member

@DamianEdwards DamianEdwards commented Mar 27, 2024

#3190

Microsoft Reviewers: Open in CodeFlow

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Mar 27, 2024
@DamianEdwards
Copy link
Member Author

/backport to release/8.0-preview5

Copy link
Contributor

Started backporting to release/8.0-preview5: https://github.com/dotnet/aspire/actions/runs/8456460198

Copy link
Member

@timheuer timheuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DamianEdwards DamianEdwards enabled auto-merge (squash) March 27, 2024 18:05
@balachir
Copy link

@DamianEdwards for the scenario described in #3190, with neither docker or podman installed, with your change, the exception message will still output Container runtime 'docker' could not be found. But now, there will be the additional aka.ms link with more info. Correct?

How does the '{0}' in the error message resolve to 'docker'? Is that because DCP tries to default to docker?

@DamianEdwards
Copy link
Member Author

@balachir From my understanding, DCP attempts to auto-detect which container runtime is installed and use that, but in the case where the error coming back doesn't have a container runtime name, Aspire.Hosting assumes Docker as the name and then adds the link now.

@DamianEdwards DamianEdwards merged commit 40fc9ea into main Mar 27, 2024
8 checks passed
@DamianEdwards DamianEdwards deleted the damianedwards/apphost-docker-ex-message branch March 27, 2024 20:24
@github-actions github-actions bot locked and limited conversation to collaborators Apr 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants