Localize "Unknown" resource state label #3402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This string appears whenever a resource status is unknown. It should be localized.
|
CI failure seems unrelated to these changes. Also occurring in #3400. |
tlmii
approved these changes
Apr 4, 2024
adamint
approved these changes
Apr 4, 2024
|
Should this be localized? Other states aren't localized. I think this change should be to put a note against the literal string that it shouldn't be localized because resource states aren't localized. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This string appears whenever a resource status is unknown. It should be localized.
Microsoft Reviewers: Open in CodeFlow