-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default to browser token auth in dashboard standalone #3427
Conversation
Very nice! Lets get this in for GA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left feedback
f4fff6c
to
f94604f
Compare
/backport to release/8.0 |
Started backporting to release/8.0: https://github.com/dotnet/aspire/actions/runs/8592957835 |
@JamesNK backporting to release/8.0 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Default to browser token auth in dashboard standalone
.git/rebase-apply/patch:359: trailing whitespace.
.git/rebase-apply/patch:368: trailing whitespace.
.git/rebase-apply/patch:377: trailing whitespace.
warning: 3 lines add whitespace errors.
Using index info to reconstruct a base tree...
M src/Aspire.Dashboard/DashboardWebApplication.cs
M src/Aspire.Dashboard/wwwroot/css/app.css
M tests/Aspire.Dashboard.Tests/Integration/StartupTests.cs
Falling back to patching base and 3-way merge...
Auto-merging tests/Aspire.Dashboard.Tests/Integration/StartupTests.cs
CONFLICT (content): Merge conflict in tests/Aspire.Dashboard.Tests/Integration/StartupTests.cs
Auto-merging src/Aspire.Dashboard/wwwroot/css/app.css
Auto-merging src/Aspire.Dashboard/DashboardWebApplication.cs
CONFLICT (content): Merge conflict in src/Aspire.Dashboard/DashboardWebApplication.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Default to browser token auth in dashboard standalone
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128 Please backport manually! |
@JamesNK an error occurred while backporting to release/8.0, please check the run log for details! Error: git am failed, most likely due to a merge conflict. |
Based on offline discussion, I've changed dashboard standalone to the default to browser token auth. Also, I noticed a number of bugs in dashboard standalone mode related to browser token auth. They're fixed in this PR.
This PR:
Demo:
Microsoft Reviewers: Open in CodeFlow