Update TestShop to store RabbitMQ password in user secrets #3446
Conversation
dotnet-issue-labeler
bot
added
the
area-app-model
DamianEdwards
changed the title
|
|
||
| public override void WriteToManifest(ManifestPublishingContext context) => parameterDefault.WriteToManifest(context); | ||
|
|
||
| private static bool TrySetUserSecret(string applicationName, string name, string value) |
There was a problem hiding this comment.
This is quite different to the way we handle user secrets in the Azure Provisioner (for example) where we load the secrets.json file directly and then save it. There are some quirks here in the way that dotnet user-secrets injects values into the secrets file. Parameters:secret name will be a flatted value at the root of the document.
There was a problem hiding this comment.
That said I'm supportive of doing something like this because it reduces friction when you clone the repo and hit F5.
There was a problem hiding this comment.
Yeah I wouldn't suggest we productize this approach and was unaware we already had code in the repo to deal with saving user secrets. I ported this from what I'm doing in the samples repo. dotnet user-secrets is the only "official" code implementation we have that saves to the secret store today so this seemed like the easiest approach for now in the playground app until we implement this idea for real.
|
|
||
| if (builder.Environment.IsDevelopment() && builder.ExecutionContext.IsRunMode) | ||
| { | ||
| // In development mode, generate a new password each time the application starts |
There was a problem hiding this comment.
I don't think this comment makes sense. We want to get it from user secrets if it is there in development mode.
| bool lower = true, bool upper = true, bool numeric = true, bool special = true, | ||
| int minLower = 0, int minUpper = 0, int minNumeric = 0, int minSpecial = 0) | ||
| { | ||
| ParameterDefault generatedPassword = new GenerateParameterDefault |
There was a problem hiding this comment.
| ParameterDefault generatedPassword = new GenerateParameterDefault | |
| ParameterDefault parameterDefault = new GenerateParameterDefault |
Since sometimes this isn't a "generatedPassword" since it could come from user secrets.
| } | ||
| } | ||
|
|
||
| sealed class ResourceBuilder |
There was a problem hiding this comment.
Do we have a problem with our Hosting code that you need to make these classes?
|
|
||
| public override void WriteToManifest(ManifestPublishingContext context) => parameterDefault.WriteToManifest(context); | ||
|
|
||
| private static bool TrySetUserSecret(string applicationName, string name, string value) |
There was a problem hiding this comment.
| private static bool TrySetUserSecret(string applicationName, string name, string value) | |
| private static void SetUserSecret(string applicationName, string name, string value) |
Nothing uses this bool.
This updates the TestShop app to automatically store the generated password for RabbitMQ in user secrets so that it runs after cloning without any further action from the developer.
This is a pattern we'll likely want to productize and have the relevant resources support (perhaps by default) as tracked in #1151
Microsoft Reviewers: Open in CodeFlow