Add Garnet Resource

[Zombach]

Implemented support request from #3428

Microsoft Reviewers: Open in CodeFlow

[Zombach]

@dotnet-policy-service agree

[mitchdenny]

Can you also integrate this with the testproject? Take a look at Redis for how it is done - we'd just want this to sit along side Redis as if it were something completely different rather than do anything clever and reuse the code between them (obviously we'll use the same client).

[Zombach]

Hello @mitchdenny. Could you watch it again?

[mitchdenny]

I don't think <remarks /> is a child element of <example /> What is AspireHost in this context -- or do you mean application host?

[mitchdenny]

OK so I've look through the XML doc comments. It's great that you've got some examples in there. I think we just need the XML doc comments applied consistently. Example:

/// <summary>A short summary of what the type/member is.</summary>
/// <remarks>
/// <para>Some longer form content with background information if
/// it would provide value.</para>
/// <para>You can use the para element to break the text up. This
/// text would not necessarily have code but would use plenty
/// of references.</para>
/// <example>
/// A description of the example and what it shows.
/// <code>
/// The actual code.
/// </code>
/// </example>
/// <example>
/// Another example with a description.
/// <code>
/// The actual code.
/// </code>
/// </example>

[Zombach]

Looks like I fixed everything

[mitchdenny]

Hello @mitchdenny. Could you watch it again?

I've read through the only thing that I think needs a touch up is the doc comments there are a few inconsistencies and (I think) invalid XML patterns. I provided an example. Once that is done we can get this merged in for 8.1!

[Zombach]

Hello @mitchdenny. Could you watch it again?

I've read through the only thing that I think needs a touch up is the doc comments there are a few inconsistencies and (I think) invalid XML patterns. I provided an example. Once that is done we can get this merged in for 8.1!

I'll try to do it in the evening.
Thank you

[mitchdenny]

Thanks for the contribution and your patience working through all the feedback!

[Zombach]

Thanks for the contribution and your patience working through all the feedback!

Thank you too. It was informative and interesting