Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/8.0] Remove constraint from templates for 8.0.1 #4181

Merged
merged 2 commits into from
May 16, 2024
Merged

[release/8.0] Remove constraint from templates for 8.0.1 #4181

merged 2 commits into from
May 16, 2024

Conversation

joperezr
Copy link
Member

@joperezr joperezr commented May 15, 2024 •
edited by dotnet-policy-service bot
Loading

Branding changes for 8.0.1 and backports #4176 to fix template constraints to avoid SDK bug.

cc: @DamianEdwards @danmoseley

Microsoft Reviewers: Open in CodeFlow

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow. intentionally a different color! label May 15, 2024
@dotnet-policy-service dotnet-policy-service bot added the Servicing-consider Issue for next servicing release review label May 15, 2024
@danmoseley danmoseley added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels May 15, 2024
@danmoseley
Copy link
Member

test failures are like

[restore] /datadisks/disk1/work/B74F09FD/w/A52B093F/e/testassets/testproject/TestProject.IntegrationServiceA/TestProject.IntegrationServiceA.csproj : error NU1603: Warning As Error: TestProject.IntegrationServiceA depends on Aspire.Confluent.Kafka (>= 8.0.0) but Aspire.Confluent.Kafka 8.0.0 was not found. An approximate best match of Aspire.Confluent.Kafka 8.0.1 was resolved. [/datadisks/disk1/work/B74F09FD/w/A52B093F/e/testassets/testproject/TestProject.AppHost/TestProject.AppHost.csproj]
[restore] /datadisks/disk1/work/B74F09FD/w/A52B093F/e/testassets/testproject/TestProject.IntegrationServiceA/TestProject.IntegrationServiceA.csproj : error NU1603: Warning As Error: TestProject.IntegrationServiceA depends on Aspire.Microsoft.Azure.Cosmos (>= 8.0.0) but Aspire.Microsoft.Azure.Cosmos 8.0.0 was not found. An approximate best match of Aspire.Microsoft.Azure.Cosmos 8.0.1 was resolved. [/datadisks/disk1/work/B74F09FD/w/A52B093F/e/testassets/testproject/TestProject.AppHost/TestProject.AppHost.csproj]
[restore] /datadisks/disk1/work/B74F09FD/w/A52B093F/e/testassets/testproject/TestProject.IntegrationServiceA/TestProject.IntegrationServiceA.csproj : error NU1603: Warning As Error: TestProject.IntegrationServiceA depends on Aspire.Microsoft.Data.SqlClient (>= 8.0.0) but Aspire.Microsoft.Data.SqlClient 8.0.0 was not found. An approximate best match of Aspire.Microsoft.Data.SqlClient 8.0.1 was resolved. [/datadisks/disk1/work/B74F09FD/w/A52B093F/e/testassets/testproject/TestProject.AppHost/TestProject.AppHost.csproj]
[restore] /datadisks/disk1/work/B74F09FD/w/A52B093F/e/testassets/testproject/TestProject.IntegrationServiceA/TestProject.IntegrationServiceA.csproj : error NU1603: Warning As Error: TestProject.IntegrationServiceA depends on Aspire.MongoDB.Driver (>= 8.0.0) but Aspire.MongoDB.Driver 8.0.0 was not found. An approximate best match of Aspire.MongoDB.Driver 8.0.1 was resolved. [/datadisks/disk1/work/B74F09FD/w/A52B093F/e/testassets/testproject/TestProject.AppHost/TestProject.AppHost.csproj]
[restore] /datadisks/disk1/work/B74F09FD/w/A52B093F/e/testassets/testproject/TestProject.IntegrationServiceA/TestProject.IntegrationServiceA.csproj : error NU1603: Warning As Error: TestProject.IntegrationServiceA depends on Aspire.MySqlConnector (>= 8.0.0) but Aspire.MySqlConnector 8.0.0 was not found. An approximate best match of Aspire.MySqlConnector 8.0.1 was resolved. [/datadisks/disk1/work/B74F09FD/w/A52B093F/e/testassets/testproject/TestProject.AppHost/TestProject.AppHost.csproj]
[restore] /datadisks/disk1/work/B74F09FD/w/A52B093F/e/testassets/testproject/TestProject.IntegrationServiceA/TestProject.IntegrationServiceA.csproj : error NU1603: Warning As Error: TestProject.IntegrationServiceA depends on Aspire.Npgsql (>= 8.0.0) but Aspire.Npgsql 8.0.0 was not found. An approximate best match of Aspire.Npgsql 8.0.1 was resolved. [/datadisks/disk1/work/B74F09FD/w/A52B093F/e/testassets/testproject/TestProject.AppHost/TestProject.AppHost.csproj]
[restore] /datadisks/disk1/work/B74F09FD/w/A52B093F/e/testassets/testproject/TestProject.IntegrationServiceA/TestProject.IntegrationServiceA.csproj : error NU1603: Warning As Error: TestProject.IntegrationServiceA depends on Aspire.Npgsql.EntityFrameworkCore.PostgreSQL (>= 8.0.0) but Aspire.Npgsql.EntityFrameworkCore.PostgreSQL 8.0.0 was not found. An approximate best match of Aspire.Npgsql.EntityFrameworkCore.PostgreSQL 8.0.1 was resolved. [/datadisks/disk1/work/B74F09FD/w/A52B093F/e/testassets/testproject/TestProject.AppHost/TestProject.AppHost.csproj]
[restore] /datadisks/disk1/work/B74F09FD/w/A52B093F/e/testassets/testproject/TestProject.IntegrationServiceA/TestProject.IntegrationServiceA.csproj : error NU1603: Warning As Error: TestProject.IntegrationServiceA depends on Aspire.Oracle.EntityFrameworkCore (>= 8.0.0) but Aspire.Oracle.EntityFrameworkCore 8.0.0 was not found. An approximate best match of Aspire.Oracle.EntityFrameworkCore 8.0.1 was resolved. [/datadisks/disk1/work/B74F09FD/w/A52B093F/e/testassets/testproject/TestProject.AppHost/TestProject.AppHost.csproj]
[restore] /datadisks/disk1/work/B74F09FD/w/A52B093F/e/testassets/testproject/TestProject.IntegrationServiceA/TestProject.IntegrationServiceA.csproj : error NU1603: Warning As Error: TestProject.IntegrationServiceA depends on Aspire.Pomelo.EntityFrameworkCore.MySql (>= 8.0.0) but Aspire.Pomelo.EntityFrameworkCore.MySql 8.0.0 was not found. An approximate best match of Aspire.Pomelo.EntityFrameworkCore.MySql 8.0.1 was resolved. [/datadisks/disk1/work/B74F09FD/w/A52B093F/e/testassets/testproject/TestProject.AppHost/TestProject.AppHost.csproj]
[restore] /datadisks/disk1/work/B74F09FD/w/A52B093F/e/testassets/testproject/TestProject.IntegrationServiceA/TestProject.IntegrationServiceA.csproj : error NU1603: Warning As Error: TestProject.IntegrationServiceA depends on Aspire.RabbitMQ.Client (>= 8.0.0) but Aspire.RabbitMQ.Client 8.0.0 was not found. An approximate best match of Aspire.RabbitMQ.Client 8.0.1 was resolved. [/datadisks/disk1/work/B74F09FD/w/A52B093F/e/testassets/testproject/TestProject.AppHost/TestProject.AppHost.csproj]
[restore] /datadisks/disk1/work/B74F09FD/w/A52B093F/e/testassets/testproject/TestProject.IntegrationServiceA/TestProject.IntegrationServiceA.csproj : error NU1603: Warning As Error: TestProject.IntegrationServiceA depends on Aspire.StackExchange.Redis (>= 8.0.0) but Aspire.StackExchange.Redis 8.0.0 was not found. An approximate best match of Aspire.StackExchange.Redis 8.0.1 was resolved. [/datadisks/disk1/work/B74F09FD/w/A52B093F/e/testassets/testproject/TestProject.AppHost/TestProject.AppHost.csproj]
[restore]   Failed to restore /datadisks/disk1/work/B74F09FD/w/A52B093F/e/testassets/testproject/TestProject.IntegrationServiceA/TestProject.IntegrationServiceA.csproj (in 24.87 sec).
[restore] /datadisks/disk1/work/B74F09FD/w/A52B093F/e/testassets/testproject/TestProject.AppHost/TestProject.AppHost.csproj : error NU1603: Warning As Error: TestProject.AppHost depends on Aspire.Hosting.AppHost (>= 8.0.0) but Aspire.Hosting.AppHost 8.0.0 was not found. An approximate best match of Aspire.Hosting.AppHost 8.0.1 was resolved.
[restore] /datadisks/disk1/work/B74F09FD/w/A52B093F/e/testassets/testproject/TestProject.AppHost/TestProject.AppHost.csproj : error NU1603: Warning As Error: TestProject.AppHost depends on Aspire.Hosting.Azure (>= 8.0.0) but Aspire.Hosting.Azure 8.0.0 was not found. An approximate best match of Aspire.Hosting.Azure 8.0.1 was resolved.
[restore] /datadisks/disk1/work/B74F09FD/w/A52B093F/e/testassets/testproject/TestProject.AppHost/TestProject.AppHost.csproj : error NU1603: Warning As Error: TestProject.AppHost depends on Aspire.Hosting.Azure.CosmosDB (>= 8.0.0) but Aspire.Hosting.Azure.CosmosDB 8.0.0 was not found. An approximate best match of Aspire.Hosting.Azure.CosmosDB 8.0.1 was resolved.
[restore] /datadisks/disk1/work/B74F09FD/w/A52B093F/e/testassets/testproject/TestProject.AppHost/TestProject.AppHost.csproj : error NU1603: Warning As Error: TestProject.AppHost depends on Aspire.Hosting.Kafka (>= 8.0.0) but Aspire.Hosting.Kafka 8.0.0 was not found. An approximate best match of Aspire.Hosting.Kafka 8.0.1 was resolved.
[restore] /datadisks/disk1/work/B74F09FD/w/A52B093F/e/testassets/testproject/TestProject.AppHost/TestProject.AppHost.csproj : error NU1603: Warning As Error: TestProject.AppHost depends on Aspire.Hosting.MongoDB (>= 8.0.0) but Aspire.Hosting.MongoDB 8.0.0 was not found. An approximate best match of Aspire.Hosting.MongoDB 8.0.1 was resolved.
[restore] /datadisks/disk1/work/B74F09FD/w/A52B093F/e/testassets/testproject/TestProject.AppHost/TestProject.AppHost.csproj : error NU1603: Warning As Error: TestProject.AppHost depends on Aspire.Hosting.MySql (>= 8.0.0) but Aspire.Hosting.MySql 8.0.0 was not found. An approximate best match of Aspire.Hosting.MySql 8.0.1 was resolved.
[restore] /datadisks/disk1/work/B74F09FD/w/A52B093F/e/testassets/testproject/TestProject.AppHost/TestProject.AppHost.csproj : error NU1603: Warning As Error: TestProject.AppHost depends on Aspire.Hosting.NodeJs (>= 8.0.0) but Aspire.Hosting.NodeJs 8.0.0 was not found. An approximate best match of Aspire.Hosting.NodeJs 8.0.1 was resolved.
[restore] /datadisks/disk1/work/B74F09FD/w/A52B093F/e/testassets/testproject/TestProject.AppHost/TestProject.AppHost.csproj : error NU1603: Warning As Error: TestProject.AppHost depends on Aspire.Hosting.Oracle (>= 8.0.0) but Aspire.Hosting.Oracle 8.0.0 was not found. An approximate best match of Aspire.Hosting.Oracle 8.0.1 was resolved.
[restore] /datadisks/disk1/work/B74F09FD/w/A52B093F/e/testassets/testproject/TestProject.AppHost/TestProject.AppHost.csproj : error NU1603: Warning As Error: TestProject.AppHost depends on Aspire.Hosting.PostgreSQL (>= 8.0.0) but Aspire.Hosting.PostgreSQL 8.0.0 was not found. An approximate best match of Aspire.Hosting.PostgreSQL 8.0.1 was resolved.
[restore] /datadisks/disk1/work/B74F09FD/w/A52B093F/e/testassets/testproject/TestProject.AppHost/TestProject.AppHost.csproj : error NU1603: Warning As Error: TestProject.AppHost depends on Aspire.Hosting.RabbitMQ (>= 8.0.0) but Aspire.Hosting.RabbitMQ 8.0.0 was not found. An approximate best match of Aspire.Hosting.RabbitMQ 8.0.1 was resolved.
[restore] /datadisks/disk1/work/B74F09FD/w/A52B093F/e/testassets/testproject/TestProject.AppHost/TestProject.AppHost.csproj : error NU1603: Warning As Error: TestProject.AppHost depends on Aspire.Hosting.Redis (>= 8.0.0) but Aspire.Hosting.Redis 8.0.0 was not found. An approximate best match of Aspire.Hosting.Redis 8.0.1 was resolved.
[restore] /datadisks/disk1/work/B74F09FD/w/A52B093F/e/testassets/testproject/TestProject.AppHost/TestProject.AppHost.csproj : error NU1603: Warning As Error: TestProject.AppHost depends on Aspire.Hosting.SqlServer (>= 8.0.0) but Aspire.Hosting.SqlServer 8.0.0 was not found. An approximate best match of Aspire.Hosting.SqlServer 8.0.1 was resolved.
[restore]   Failed to restore /datadisks/disk1/work/B74F09FD/w/A52B093F/e/testassets/testproject/TestProject.AppHost/TestProject.AppHost.csproj (in 20.84 sec).

@danmoseley
Copy link
Member

this doesn't make logical sense? at a minimum the error message should be improved:
depends on XXX (>= 8.0.0) but XXX 8.0.0 was not found. An approximate best match of XXX 8.0.1 was resolved.
whatever the fix on our side, do we need a bug against nuget for the message

@joperezr
Copy link
Member Author

Oh yes thanks! I know what's wrong, I missed one tiny change, will add in a bit.

@danmoseley
Copy link
Member

aspire/tests/testproject/Directory.Packages.Helix.props

Line 11 in 889ff29

<_PackageVersion Condition="'$(StabilizePackageVersion)' == 'true'">8.0.0</_PackageVersion>

@DamianEdwards
Copy link
Member

@danmoseley that message is saying "you asked for 8.0.0 but I couldn't find an 8.0.0 in any configured feed, but I did find an 8.0.1 which is valid according to NuGet default rules where the version specified is actually the minimum version"

@joperezr joperezr merged commit e131826 into dotnet:release/8.0 May 16, 2024
8 checks passed
@danmoseley
Copy link
Member

"you asked for 8.0.0 but I couldn't find an 8.0.0 in any configured feed, but I did find an 8.0.1 which is valid according to NuGet default rules where the version specified is actually the minimum version"

I figured, then I think the but and approximate makes that not clear. maybe eg
...depends on XXX (>= 8.0.0). XXX 8.0.0 was preferred but not found. A next best match of XXX 8.0.1 was resolved.

@danmoseley
Copy link
Member

NuGet/Home#13446 fwiw

@joperezr joperezr deleted the FixTemplates801 branch May 16, 2024 20:59
@github-actions github-actions bot locked and limited conversation to collaborators Jun 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DamianEdwards DamianEdwards DamianEdwards approved these changes

Assignees
No one assigned
Labels
area-codeflow for labeling automated codeflow. intentionally a different color! Servicing-approved Approved for servicing release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joperezr @danmoseley @DamianEdwards