Allow for customization of the Azure ProvisioningContext + Better Azure resource name scheme #5809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add IOptions<AzureProvisioningOptions> which contains a ProvisioningContext. Users can customize the ProvisioningContext by configuring the AzureProvisioningOptions like a typical IOptions.
Open
3 tasks
Use a property on AzureConstructResource instead of flowing the ProvisioningContext through to the GetBicep methods.
davidfowl
reviewed
Sep 20, 2024
| @@ -55,8 +56,7 @@ public override BicepTemplateFile GetBicepTemplateFile(string? directory = null, | |||
| var generationPath = Directory.CreateTempSubdirectory("aspire").FullName; | |||
| var moduleSourcePath = Path.Combine(generationPath, "main.bicep"); | |||
|
|
|||
| var provisioningContext = GetProvisioningContext(); | |||
| var plan = resourceModuleConstruct.Build(provisioningContext); | |||
| var plan = resourceModuleConstruct.Build(ProvisioningContext); | |||
There was a problem hiding this comment.
You still need a fallback if this isn't set.
There was a problem hiding this comment.
It allows null.
It uses the context ??= ProvisioningContext.Provider.GetProvisioningContext();.
@tg-msft - is that going to change at all with the changes to remove the DefaultInfrastructure you were mentioning?
davidfowl
reviewed
Sep 21, 2024
eerhardt
added
the
breaking-change
|
This PR is now ready for review. |
davidfowl
reviewed
Sep 23, 2024
davidfowl
approved these changes
Sep 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add IOptions which contains a ProvisioningContext. Users can customize the ProvisioningContext by configuring the AzureProvisioningOptions like a typical IOptions.
This allows us to use the new CDK default naming scheme. Users can opt into the old scheme by customizing the ProvisioningContext.
Fix #5756
Fix #5341
Checklist
<remarks />and<code />elements on your triple slash comments?Microsoft Reviewers: Open in CodeFlow