Support OData Collection Parameters #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+497
to
+506
| foreach ( var parameter in function.Parameters ) | ||
| { | ||
| if ( parameter.Type.IsCollection() && | ||
| mapping.TryGetValue( parameter.Name, out name ) && | ||
| parameters.SingleOrDefault( p => p.Name == name ) is { } param ) | ||
| { | ||
| param.Source = BindingSource.Path; | ||
| break; | ||
| } | ||
| } |
Check notice
Code scanning / CodeQL
Missed opportunity to use Where Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support OData Collection Parameters
Description
This PR adds support for OData collection parameters via the API Explorer for OData functions. The value format is unique to OData functions in the URL. OData actions can have collection parameters in the body as normal JSON arrays. The support only includes primitives, which includes enumerations. OData allows Complex Types, but that is not currently supported.
The issue of formatted or escaped string values cannot be solved. This is a limitation in OpenAPI. A user must input
stringvalues as'text'or"text"unless the author provides some other extension to the Swagger UI to handle quoting of user input.Spanrather thanstring.Format