Remove obsolete IHttpBufferingFeature, IHttpSendFileFeature #27529

dotnet · Dec 29, 2020 · 72b1ffa · 72b1ffa
1 parent 6e25d1c
commit 72b1ffa
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 70 deletions.
diff --git a/src/Http/Http.Features/src/IHttpBufferingFeature.cs b/src/Http/Http.Features/src/IHttpBufferingFeature.cs
diff --git a/src/Http/Http.Features/src/IHttpSendFileFeature.cs b/src/Http/Http.Features/src/IHttpSendFileFeature.cs
diff --git a/src/Http/Http.Features/src/PublicAPI.Shipped.txt b/src/Http/Http.Features/src/PublicAPI.Shipped.txt
@@ -61,9 +61,6 @@ Microsoft.AspNetCore.Http.Features.IFormFeature.ReadFormAsync(System.Threading.C
 Microsoft.AspNetCore.Http.Features.IHttpBodyControlFeature
 Microsoft.AspNetCore.Http.Features.IHttpBodyControlFeature.AllowSynchronousIO.get -> bool
 Microsoft.AspNetCore.Http.Features.IHttpBodyControlFeature.AllowSynchronousIO.set -> void
-Microsoft.AspNetCore.Http.Features.IHttpBufferingFeature
-Microsoft.AspNetCore.Http.Features.IHttpBufferingFeature.DisableRequestBuffering() -> void
-Microsoft.AspNetCore.Http.Features.IHttpBufferingFeature.DisableResponseBuffering() -> void
 Microsoft.AspNetCore.Http.Features.IHttpConnectionFeature
 Microsoft.AspNetCore.Http.Features.IHttpConnectionFeature.ConnectionId.get -> string!
 Microsoft.AspNetCore.Http.Features.IHttpConnectionFeature.ConnectionId.set -> void
@@ -134,8 +131,6 @@ Microsoft.AspNetCore.Http.Features.IHttpResponseFeature.StatusCode.set -> void
 Microsoft.AspNetCore.Http.Features.IHttpResponseTrailersFeature
 Microsoft.AspNetCore.Http.Features.IHttpResponseTrailersFeature.Trailers.set -> void
 Microsoft.AspNetCore.Http.Features.IHttpResponseTrailersFeature.Trailers.get -> Microsoft.AspNetCore.Http.IHeaderDictionary!
-Microsoft.AspNetCore.Http.Features.IHttpSendFileFeature
-Microsoft.AspNetCore.Http.Features.IHttpSendFileFeature.SendFileAsync(string! path, long offset, long? count, System.Threading.CancellationToken cancellation) -> System.Threading.Tasks.Task!
 Microsoft.AspNetCore.Http.Features.IHttpUpgradeFeature
 Microsoft.AspNetCore.Http.Features.IHttpUpgradeFeature.IsUpgradableRequest.get -> bool
 Microsoft.AspNetCore.Http.Features.IHttpUpgradeFeature.UpgradeAsync() -> System.Threading.Tasks.Task<System.IO.Stream!>!

diff --git a/src/Servers/testassets/ServerComparison.TestSites/StartupResponseCompression.cs b/src/Servers/testassets/ServerComparison.TestSites/StartupResponseCompression.cs
@@ -41,19 +41,6 @@ public void Configure(IApplicationBuilder app, ILoggerFactory loggerFactory)
                     return context.Response.WriteAsync(helloWorldBody);
                 });
             });
-            /* If we implement DisableResponseBuffering on IISMiddleware
-            app.Map("/NoBuffer", subApp =>
-            {
-                subApp.UseResponseCompression();
-                subApp.Run(context =>
-                {
-                    context.Features.Get<IHttpBufferingFeature>().DisableResponseBuffering();
-                    context.Response.ContentType = "text/plain";
-                    context.Response.ContentLength = helloWorldBody.Length;
-                    return context.Response.WriteAsync(helloWorldBody);
-                });
-            });
-            */
             app.Run(context =>
             {
                 context.Response.ContentType = "text/plain";