Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
JamesNK authored Jun 28, 2024
1 parent 432a534 commit 899f687
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
namespace Microsoft.AspNetCore.Http;

/// <summary>
/// Specifies that an HTTP duration metric is disabled for an endpoint.
/// Specifies that HTTP request duration metrics is disabled for an endpoint.
/// </summary>
[AttributeUsage(AttributeTargets.Method | AttributeTargets.Class)]
public sealed class DisableHttpMetricsAttribute : Attribute, IDisableHttpMetricsMetadata
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ namespace Microsoft.AspNetCore.Builder;
public static class HttpMetricsEndpointConventionBuilderExtensions
{
/// <summary>
/// Specifies that an HTTP duration metric is disabled for an endpoint.
/// Specifies that HTTP request duration metrics is disabled for an endpoint.
/// </summary>
/// <typeparam name="TBuilder">The type of endpoint convention builder.</typeparam>
/// <param name="builder">The endpoint convention builder.</param>
Expand Down
4 changes: 2 additions & 2 deletions src/Http/Http.Features/src/IHttpMetricsTagsFeature.cs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
namespace Microsoft.AspNetCore.Http.Features;

/// <summary>
/// Provides access to tags added to the metrics HTTP request duration counter. This feature isn't set if the counter isn't enabled.
/// Provides access to tags added to HTTP request duration metrics. This feature isn't set if the counter isn't enabled.
/// </summary>
public interface IHttpMetricsTagsFeature
{
Expand All @@ -15,7 +15,7 @@ public interface IHttpMetricsTagsFeature

// MetricsDisabled was added after the initial release of this interface and is intentionally a DIM property.
/// <summary>
/// Gets or sets a flag that disables recording HTTP request duration counter for the current HTTP request.
/// Gets or sets a flag that disables recording HTTP request duration metrics for the current HTTP request.
/// </summary>
public bool MetricsDisabled { get; set; }
}

0 comments on commit 899f687

Please sign in to comment.