!temporary! Add [Repeat] attributes for all re-enabled tests

- double-check none wer skipped for flakiness
dotnet · Sep 7, 2020 · a95abdb · a95abdb
1 parent d8fc4dc
commit a95abdb
Show file tree

Hide file tree

Showing 15 changed files with 25 additions and 0 deletions.
diff --git a/src/Components/test/E2ETest/Tests/WebAssemblyStringComparisonTest.cs b/src/Components/test/E2ETest/Tests/WebAssemblyStringComparisonTest.cs
@@ -5,6 +5,7 @@
 using Microsoft.AspNetCore.Components.E2ETest.Infrastructure;
 using Microsoft.AspNetCore.Components.E2ETest.Infrastructure.ServerFixtures;
 using Microsoft.AspNetCore.E2ETesting;
+using Microsoft.AspNetCore.Testing;
 using OpenQA.Selenium;
 using Xunit;
 using Xunit.Abstractions;
@@ -22,6 +23,7 @@ public WebAssemblyStringComparisonTest(
         }
 
         [Fact]
+        [Repeat]
         public void InvariantCultureWorksAsExpected()
         {
             Navigate(ServerPathBase, noReload: false);

diff --git a/src/MusicStore/test/MusicStore.Test/ShoppingCartControllerTest.cs b/src/MusicStore/test/MusicStore.Test/ShoppingCartControllerTest.cs
@@ -7,6 +7,7 @@
 using Microsoft.AspNetCore.Http;
 using Microsoft.AspNetCore.Http.Features;
 using Microsoft.AspNetCore.Mvc;
+using Microsoft.AspNetCore.Testing;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Logging;
 using Microsoft.Extensions.Primitives;
@@ -78,6 +79,7 @@ public async Task Index_ReturnsNoCartItems_WhenNoItemsInCart()
         }
 
         [Fact]
+        [Repeat]
         public async Task Index_ReturnsCartItems_WhenItemsInCart()
         {
             // Arrange
@@ -114,6 +116,7 @@ public async Task Index_ReturnsCartItems_WhenItemsInCart()
         }
 
         [Fact]
+        [Repeat]
         public async Task AddToCart_AddsItemToCart()
         {
             // Arrange
@@ -156,6 +159,7 @@ public async Task AddToCart_AddsItemToCart()
         }
 
         [Fact]
+        [Repeat]
         public async Task RemoveFromCart_RemovesItemFromCart()
         {
             // Arrange

diff --git a/src/Mvc/test/Mvc.FunctionalTests/RazorPagesTest.cs b/src/Mvc/test/Mvc.FunctionalTests/RazorPagesTest.cs
@@ -805,6 +805,7 @@ public async Task PolymorphicPropertiesOnPageModelsAreBound()
         }
 
         [Fact]
+        [Repeat]
         public async Task PolymorphicPropertiesOnPageModelsAreValidated()
         {
             // Arrange

diff --git a/src/Mvc/test/Mvc.FunctionalTests/SystemTextJsonInputFormatterTest.cs b/src/Mvc/test/Mvc.FunctionalTests/SystemTextJsonInputFormatterTest.cs
@@ -2,10 +2,12 @@
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
 using System.Threading.Tasks;
+using Microsoft.AspNetCore.Testing;
 using Xunit;
 
 namespace Microsoft.AspNetCore.Mvc.FunctionalTests
 {
+    [Repeat]
     public class SystemTextJsonInputFormatterTest : JsonInputFormatterTestBase<FormatterWebSite.StartupWithJsonFormatter>
     {
         public SystemTextJsonInputFormatterTest(MvcTestFixture<FormatterWebSite.StartupWithJsonFormatter> fixture)

diff --git a/src/Mvc/test/Mvc.IntegrationTests/ComplexTypeIntegrationTestBase.cs b/src/Mvc/test/Mvc.IntegrationTests/ComplexTypeIntegrationTestBase.cs
@@ -1853,6 +1853,7 @@ public async Task ComplexBinder_BindsKeyValuePairProperty_EmptyPrefix_Success()
         }
 
         [Fact]
+        [Repeat]
         public async Task ComplexBinder_BindsKeyValuePairProperty_NoCollectionData()
         {
             // Arrange
@@ -1902,6 +1903,7 @@ public async Task ComplexBinder_BindsKeyValuePairProperty_NoCollectionData()
         }
 
         [Fact]
+        [Repeat]
         public async Task ComplexBinder_BindsKeyValuePairProperty_NoData()
         {
             // Arrange

diff --git a/src/Mvc/test/Mvc.IntegrationTests/KeyValuePairModelBinderIntegrationTest.cs b/src/Mvc/test/Mvc.IntegrationTests/KeyValuePairModelBinderIntegrationTest.cs
@@ -6,6 +6,7 @@
 using Microsoft.AspNetCore.Http;
 using Microsoft.AspNetCore.Mvc.Abstractions;
 using Microsoft.AspNetCore.Mvc.ModelBinding;
+using Microsoft.AspNetCore.Testing;
 using Xunit;
 
 namespace Microsoft.AspNetCore.Mvc.IntegrationTests
@@ -312,6 +313,7 @@ public async Task KeyValuePairModelBinder_BindsKeyValuePairOfSimpleType_EmptyPre
         }
 
         [Fact]
+        [Repeat]
         public async Task KeyValuePairModelBinder_BindsKeyValuePairOfSimpleType_NoData()
         {
             // Arrange
@@ -477,6 +479,7 @@ public async Task KeyValuePairModelBinder_BindsKeyValuePairOfComplexType_EmptyPr
         }
 
         [Fact]
+        [Repeat]
         public async Task KeyValuePairModelBinder_BindsKeyValuePairOfComplexType_NoData()
         {
             // Arrange

diff --git a/src/ProjectTemplates/test/EmptyWebTemplateTest.cs b/src/ProjectTemplates/test/EmptyWebTemplateTest.cs
@@ -32,6 +32,7 @@ public async Task EmptyWebTemplateCSharp()
 
         [ConditionalFact]
         [SkipOnHelix("Cert failures", Queues = "OSX.1014.Amd64;OSX.1014.Amd64.Open")]
+        [Repeat]
         public async Task EmptyWebTemplateFSharp()
         {
             await EmtpyTemplateCore("F#");

diff --git a/src/ProjectTemplates/test/MvcTemplateTest.cs b/src/ProjectTemplates/test/MvcTemplateTest.cs
@@ -28,6 +28,7 @@ public MvcTemplateTest(ProjectFactoryFixture projectFactory, ITestOutputHelper o
 
         [ConditionalFact]
         [SkipOnHelix("cert failure", Queues = "OSX.1014.Amd64;OSX.1014.Amd64.Open")]
+        [Repeat]
         public async Task MvcTemplate_NoAuthFSharp() => await MvcTemplateCore(languageOverride: "F#");
 
         [ConditionalFact]

diff --git a/src/ProjectTemplates/test/WebApiTemplateTest.cs b/src/ProjectTemplates/test/WebApiTemplateTest.cs
@@ -34,6 +34,7 @@ public WebApiTemplateTest(ProjectFactoryFixture factoryFixture, ITestOutputHelpe
 
         [ConditionalFact]
         [SkipOnHelix("Cert failures", Queues = "OSX.1014.Amd64;OSX.1014.Amd64.Open")]
+        [Repeat]
         public Task WebApiTemplateFSharp() => WebApiTemplateCore(languageOverride: "F#");
 
         [ConditionalFact]

diff --git a/src/ProjectTemplates/test/WorkerTemplateTest.cs b/src/ProjectTemplates/test/WorkerTemplateTest.cs
@@ -2,6 +2,7 @@
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
 using System.Threading.Tasks;
+using Microsoft.AspNetCore.Testing;
 using Templates.Test.Helpers;
 using Xunit;
 using Xunit.Abstractions;
@@ -23,6 +24,7 @@ public WorkerTemplateTest(ProjectFactoryFixture projectFactory, ITestOutputHelpe
         [Theory]
         [InlineData("C#")]
         [InlineData("F#")]
+        [Repeat]
         public async Task WorkerTemplateAsync(string language)
         {
             Project = await ProjectFactory.GetOrCreateProject(

diff --git a/...Razor/Microsoft.NET.Sdk.Razor/integrationtests/ApplicationPartDiscoveryIntegrationTest.cs b/...Razor/Microsoft.NET.Sdk.Razor/integrationtests/ApplicationPartDiscoveryIntegrationTest.cs
@@ -23,6 +23,7 @@ public Task Build_ProjectWithDependencyThatReferencesMvc_AddsAttribute_WhenBuild
         [ConditionalFact]
         [OSSkipCondition(OperatingSystems.Linux | OperatingSystems.MacOSX)]
         [InitializeTestProject("AppWithP2PReference", additionalProjects: "ClassLibrary")]
+        [Repeat]
         public Task Build_ProjectWithDependencyThatReferencesMvc_AddsAttribute_WhenBuildingUsingDesktopMsbuild()
             => Build_ProjectWithDependencyThatReferencesMvc_AddsAttribute(MSBuildProcessKind.Desktop);
 

diff --git a/src/Security/test/AuthSamples.FunctionalTests/IdentityExternalClaimsTests.cs b/src/Security/test/AuthSamples.FunctionalTests/IdentityExternalClaimsTests.cs
@@ -5,6 +5,7 @@
 using System.Net.Http;
 using System.Threading.Tasks;
 using Microsoft.AspNetCore.Mvc.Testing;
+using Microsoft.AspNetCore.Testing;
 using Xunit;
 
 namespace AuthSamples.FunctionalTests
@@ -30,6 +31,7 @@ public async Task DefaultReturns200()
         }
 
         [Fact]
+        [Repeat]
         public async Task MyClaimsRedirectsToLoginPageWhenNotLoggedIn()
         {
             // Arrange & Act

diff --git a/src/Servers/IIS/IIS/test/Common.FunctionalTests/AppOfflineTests.cs b/src/Servers/IIS/IIS/test/Common.FunctionalTests/AppOfflineTests.cs
@@ -78,6 +78,7 @@ public async Task AppOfflineDroppedWhileSiteFailedToStartInShim_AppOfflineServed
         }
 
         [ConditionalFact]
+        [Repeat]
         public async Task AppOfflineDroppedWhileSiteFailedToStartInRequestHandler_SiteStops_InProcess()
         {
             var deploymentResult = await DeployApp(HostingModel.InProcess);

diff --git a/src/Servers/IIS/IIS/test/Common.FunctionalTests/Inprocess/ClientDisconnectTests.cs b/src/Servers/IIS/IIS/test/Common.FunctionalTests/Inprocess/ClientDisconnectTests.cs
@@ -67,6 +67,7 @@ await connection.Send(
         }
 
         [ConditionalFact]
+        [Repeat]
         public async Task ClientDisconnectCallbackStress()
         {
             // Fixture initialization fails if inside of the Task.Run, so send an

diff --git a/src/Servers/Kestrel/test/Interop.FunctionalTests/ChromeTests.cs b/src/Servers/Kestrel/test/Interop.FunctionalTests/ChromeTests.cs
@@ -68,6 +68,7 @@ private void InitializeArgs()
         [MinimumOSVersion(OperatingSystems.Windows, WindowsVersions.Win81, SkipReason = "Missing Windows ALPN support: https://en.wikipedia.org/wiki/Application-Layer_Protocol_Negotiation#Support")]
         [InlineData("", "Interop HTTP/2 GET")]
         [InlineData("?TestMethod=POST", "Interop HTTP/2 POST")]
+        [Repeat]
         public async Task Http2(string requestSuffix, string expectedResponse)
         {
             InitializeArgs();