-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Razor implicit/explicit expressions in HTML attributes are not colored properly #20140
Labels
Milestone
Comments
NTaylorMullen
added
bug
This issue describes a behavior which is not expected - a bug.
cost: S
area-mvc
Includes: MVC, Actions and Controllers, Localization, CORS, most templates
labels
Mar 25, 2020
NTaylorMullen
changed the title
Razor implicit expressions in HTML attributes are not colored properly
Razor implicit/explicit expressions in HTML attributes are not colored properly
Mar 25, 2020
NTaylorMullen
added a commit
to dotnet/razor
that referenced
this issue
Mar 25, 2020
- This makes our new Razor LSP editor bits look almost identical to the existing VS experience. - There are several issues in regards to C# in attributes and that's tracked here: dotnet/aspnetcore#20140 - There's no semantic colorization for tags or C# yet either so that breaks down the colorization expected for our Blazor components and TagHelpers. - Had to name the textmate grammar with the specific name of `aspnetcorerazor.tmLanguage.tmTheme` in order to enable the VS themeing support to locate our theme. - One big colorization difference that can't currently be supported is the background coloring of our C# bits. This is something VS' CoreEditor is willing to change on our behalf though. Fixes dotnet/aspnetcore#18769
NTaylorMullen
modified the milestones:
Razor LSP Preview 3,
Razor LSP VS Client Alpha 1
Mar 25, 2020
This impacts the immediate colorization experience of the Razor editor in default templates. Pulling into our alpha release. |
NTaylorMullen
added a commit
to dotnet/razor
that referenced
this issue
Mar 26, 2020
- This makes our new Razor LSP editor bits look almost identical to the existing VS experience. - There are several issues in regards to C# in attributes and that's tracked here: dotnet/aspnetcore#20140 - There's no semantic colorization for tags or C# yet either so that breaks down the colorization expected for our Blazor components and TagHelpers. - Had to name the textmate grammar with the specific name of `aspnetcorerazor.tmLanguage.tmTheme` in order to enable the VS themeing support to locate our theme. - One big colorization difference that can't currently be supported is the background coloring of our C# bits. This is something VS' CoreEditor is willing to change on our behalf though. Fixes dotnet/aspnetcore#18769
NTaylorMullen
modified the milestones:
Razor LSP VS Client Alpha 1,
Razor.Tooling,
Razor LSP VS Client Alpha 2
Apr 6, 2020
FYI: @ryanbrandenburg @noahbkim Sample Text to try this out during validations (screenshots of before / after are in the PR). Explicit
Implicit
|
ghost
locked as resolved and limited conversation to collaborators
Jun 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Our TextMate grammar doesn't look like it properly supports Razor expressions in HTML attributes.
Easiest way to repro is to create a new Blazor project and then open
NavMenu.razor
. There's this line that doesn't colorize correctly:The text was updated successfully, but these errors were encountered: