Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Virtualization fixes #25535

Closed
SteveSandersonMS opened this issue Sep 2, 2020 · 0 comments · Fixed by #25260
Closed

Virtualization fixes #25535

SteveSandersonMS opened this issue Sep 2, 2020 · 0 comments · Fixed by #25260
Assignees
@SteveSandersonMS @MackinnonBuck
Labels
area-blazor Includes: Blazor, Razor Components bug This issue describes a behavior which is not expected - a bug. Done This issue has been fixed
Milestone
5.0.0-rc2

Comments

@SteveSandersonMS
Copy link
Member

Resolve the two main remaining usability issues:

  • Item size calculations can be wrong by a subpixel amount, which accumulates and produces offsets in scrolling
  • When items don't have @key, scrolling can get stuck in a loop
@SteveSandersonMS SteveSandersonMS added the area-blazor Includes: Blazor, Razor Components label Sep 2, 2020
@SteveSandersonMS SteveSandersonMS added this to the 5.0.0-rc1 milestone Sep 2, 2020
@SteveSandersonMS SteveSandersonMS linked a pull request Sep 2, 2020 that will close this issue
Various virtualization improvements. Fixes #25535 #25260
Merged
@SteveSandersonMS SteveSandersonMS added the bug This issue describes a behavior which is not expected - a bug. label Sep 2, 2020
@MackinnonBuck MackinnonBuck mentioned this issue Sep 2, 2020
Merged
mkArtakMSFT pushed a commit that referenced this issue Sep 3, 2020
@MackinnonBuck @SteveSandersonMS
Various virtualization improvements. Fixes #25535 (#25260)
8418ef6 
* Use ItemSize if it's close to the calculated item size.

* Update WeatherForecastService.cs

* Improved item size calculation.

* Always use calculated item size

* Disable overflow anchoring on scroll containers (except the document itself)

* Update JS files following rebase

* Apply overflow anchor fix to document element too

* Add OverscanCount parameter

Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
@mkArtakMSFT mkArtakMSFT modified the milestones: 5.0.0-rc1, 5.0.0-rc2 Sep 3, 2020
@ghost ghost added Done This issue has been fixed and removed Working labels Sep 3, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Oct 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@SteveSandersonMS SteveSandersonMS

@MackinnonBuck MackinnonBuck

Labels
area-blazor Includes: Blazor, Razor Components bug This issue describes a behavior which is not expected - a bug. Done This issue has been fixed
Projects
None yet
Milestone
5.0.0-rc2
Development

Successfully merging a pull request may close this issue.

Various virtualization improvements. Fixes #25535 dotnet/aspnetcore
3 participants
@SteveSandersonMS @MackinnonBuck @mkArtakMSFT