Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotnet-watch: Update agents to pass the list of changed types to MetadataUpdateHandlers #33792

Closed
pranavkm opened this issue Jun 23, 2021 · 1 comment · Fixed by dotnet/sdk#18591
Assignees
Labels
area-commandlinetools Includes: Command line tools, dotnet-dev-certs, dotnet-user-jwts, and OpenAPI Done This issue has been fixed
Milestone

Comments

@pranavkm
Copy link
Contributor

The current implementation passes null value to the handler methods. The agents should be updated to pass-thru a list of changed types that are read from the compiler.

@pranavkm pranavkm added the area-commandlinetools Includes: Command line tools, dotnet-dev-certs, dotnet-user-jwts, and OpenAPI label Jun 23, 2021
@pranavkm pranavkm added this to the Next sprint planning milestone Jun 23, 2021
@ghost
Copy link

ghost commented Jun 23, 2021

Thanks for contacting us.

We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@pranavkm pranavkm self-assigned this Jun 28, 2021
@ghost ghost added the Working label Jun 28, 2021
pranavkm added a commit to dotnet/sdk that referenced this issue Jun 29, 2021
* Include UpdatedTypes as part of MetadataUpdateHandler calls

Fixes dotnet/aspnetcore#33792
@ghost ghost added Done This issue has been fixed and removed Working labels Jun 29, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jul 29, 2021
filipnavara pushed a commit to filipnavara/dotnet-hotrewatch that referenced this issue Oct 23, 2021
* Include UpdatedTypes as part of MetadataUpdateHandler calls

Fixes dotnet/aspnetcore#33792
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-commandlinetools Includes: Command line tools, dotnet-dev-certs, dotnet-user-jwts, and OpenAPI Done This issue has been fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant