Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blazor SDK Targets Packaging Fixes #38844

Closed
TanayParikh opened this issue Dec 6, 2021 · 1 comment · Fixed by dotnet/sdk#22945
Closed

Blazor SDK Targets Packaging Fixes #38844

TanayParikh opened this issue Dec 6, 2021 · 1 comment · Fixed by dotnet/sdk#22945
Assignees
Labels
area-blazor Includes: Blazor, Razor Components feature-static-web-assets task
Milestone

Comments

@TanayParikh
Copy link
Contributor

TanayParikh commented Dec 6, 2021

It's the files package.json and dotnet.d.ts which I added to native of the Microsoft.NETCore.App.Runtime.Mono.browser-wasm.7.0.0-dev.nupkg in runtimes\browser-wasm\native. Each of them twice, once as is, and second as .gz, that's why 4 new items in the diff.

The Blazor would put those files into wwwroot_framework
I think that they would do not harm in there, but I would prefer to keep them compile time files, not copied to wwwroot.
How is that achieved ?

This is a rough corner of how we build the runtime pack, I suspect the new files are probably just escaping a work around in the blazor sdk targets. We should fix that but I'd like to solve the underlying problem as well.

cc @TanayParikh @javiercn

Originally posted by @lewing in dotnet/sdk#22892 (comment)

@SteveSandersonMS
Copy link
Member

Still to be determined if we definitely need to do something here.

@TanayParikh TanayParikh self-assigned this Dec 7, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jan 8, 2022
@danroth27 danroth27 added the task label Sep 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-blazor Includes: Blazor, Razor Components feature-static-web-assets task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants