[main] Update dependencies from dotnet/runtime #22892

dotnet-maestro · 2021-12-03T13:19:32Z

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

Subscription: aa69f164-2492-460a-3914-08d8e9750bf8
Build: 20211206.1
Date Produced: December 6, 2021 12:21:20 PM UTC
Commit: 8929153f16c841cfd6269f511d4c0b65ba5d1965
Branch: refs/heads/main

Updates:
- Microsoft.NETCore.Platforms: from 7.0.0-alpha.1.21602.1 to 7.0.0-alpha.1.21606.1
- Microsoft.NETCore.DotNetHostResolver: from 7.0.0-alpha.1.21602.1 to 7.0.0-alpha.1.21606.1
- Microsoft.NETCore.App.Runtime.win-x64: from 7.0.0-alpha.1.21602.1 to 7.0.0-alpha.1.21606.1
- System.CodeDom: from 7.0.0-alpha.1.21602.1 to 7.0.0-alpha.1.21606.1
- System.Security.Cryptography.ProtectedData: from 7.0.0-alpha.1.21602.1 to 7.0.0-alpha.1.21606.1
- System.Resources.Extensions: from 7.0.0-alpha.1.21602.1 to 7.0.0-alpha.1.21606.1
- System.Reflection.MetadataLoadContext: from 7.0.0-alpha.1.21602.1 to 7.0.0-alpha.1.21606.1
- Microsoft.NET.HostModel: from 7.0.0-alpha.1.21602.1 to 7.0.0-alpha.1.21606.1
- Microsoft.Extensions.DependencyModel: from 7.0.0-alpha.1.21602.1 to 7.0.0-alpha.1.21606.1
- Microsoft.NETCore.App.Host.win-x64: from 7.0.0-alpha.1.21602.1 to 7.0.0-alpha.1.21606.1
- Microsoft.NETCore.App.Ref: from 7.0.0-alpha.1.21602.1 to 7.0.0-alpha.1.21606.1
- System.Text.Encoding.CodePages: from 7.0.0-alpha.1.21602.1 to 7.0.0-alpha.1.21606.1
- VS.Redist.Common.NetCore.SharedFramework.x64.7.0: from 7.0.0-alpha.1.21602.1 to 7.0.0-alpha.1.21606.1
- VS.Redist.Common.NetCore.TargetingPack.x64.7.0: from 7.0.0-alpha.1.21602.1 to 7.0.0-alpha.1.21606.1

…1203.1 Microsoft.NETCore.Platforms , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.App.Runtime.win-x64 , System.CodeDom , System.Security.Cryptography.ProtectedData , System.Resources.Extensions , System.Reflection.MetadataLoadContext , Microsoft.NET.HostModel , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.7.0 , VS.Redist.Common.NetCore.TargetingPack.x64.7.0 From Version 7.0.0-alpha.1.21602.1 -> To Version 7.0.0-alpha.1.21603.1

dotnet-maestro · 2021-12-03T14:15:07Z

Notification for subscribed users from https://github.com/dotnet/runtime:

@dnr-codeflow

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

This pull request contains changes from your source repo (https://github.com/dotnet/runtime) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
For more details, please read the Arcade Darc documentation

danmoseley · 2021-12-03T19:05:59Z

Build_DoesNotGenerateManifestJson_IncludesJSModulesOnBlazorBootJsonManifest and and JSModules_ManifestIncludesModuleTargetPaths are failing
Assertion failure is AssertManifest(manifest, LoadBuildManifest());

    Microsoft.NET.Sdk.BlazorWebAssembly.Tests.WasmJsModulesIntegrationTests.Build_DoesNotGenerateManifestJson_IncludesJSModulesOnBlazorBootJsonManifest [FAIL]
      Expected subject to be a collection with 404 item(s), but found 408.
      
With configuration:
- Use declared types and members
      - Compare enums by value
      - Match member by name (or throw)
      - Be strict about the order of items in byte arrays
      
      Stack Trace:
           at FluentAssertions.Execution.XUnit2TestFramework.Throw(String message)
           at FluentAssertions.Execution.TestFrameworkProvider.Throw(String message)
           at FluentAssertions.Execution.CollectingAssertionStrategy.ThrowIfAny(IDictionary`2 context)
           at FluentAssertions.Equivalency.EquivalencyValidator.AssertEquality(EquivalencyValidationContext context)
           at FluentAssertions.AssertionExtensions.ShouldBeEquivalentTo[T](T subject, Object expectation, Func`2 config, String because, Object[] becauseArgs)
           at FluentAssertions.AssertionExtensions.ShouldBeEquivalentTo[T](T subject, Object expectation, String because, Object[] becauseArgs)
        /_/src/Tests/Microsoft.NET.Sdk.Razor.Tests/AspNetSdkBaselineTest.cs(359,0): at Microsoft.NET.Sdk.Razor.Tests.AspNetSdkBaselineTest.AssertManifest(StaticWebAssetsManifest manifest, StaticWebAssetsManifest expected, String suffix, String name)
        /_/src/Tests/Microsoft.NET.Sdk.BlazorWebAssembly.Tests/WasmJsModulesIntegrationTests.cs(44,0): at Microsoft.NET.Sdk.BlazorWebAssembly.Tests.WasmJsModulesIntegrationTests.Build_DoesNotGenerateManifestJson_IncludesJSModulesOnBlazorBootJsonManifest()
      ...
Running C:\h\w\AFC50921\p\d\dotnet.exe msbuild /t:Build C:\h\w\AFC50921\t\dotnetSdkTests\zyyz1vbm.oez\JSModules_Man---0E797D5D\blazorhosted\blazorhosted.csproj /restore /bl
Process ID: 3404
    Microsoft.NET.Sdk.BlazorWebAssembly.Tests.WasmJsModulesIntegrationTests.JSModules_ManifestIncludesModuleTargetPaths [FAIL]
      Expected subject to be a collection with 415 item(s), but found 419.

@lewing is there someone who could take a look? I figured it might be a baseline update, but it looks like not.
(or perhaps this is an ASP.NET team thing)_

danmoseley · 2021-12-03T19:08:28Z

also some failures in Microsoft.DotNet.Watcher.Tools.NoDepsAppTests, and the similar failure in
ANET461ProjectCanReferenceANETStandardProject:

        C:\h\w\A10F099F\t\dotnetSdkTests\frorbrtg.sfn\RestartProces---6C6A686B\WatchNoDepsApp.csproj : error : C:\h\w\A10F099F\p\d\sdk\7.0.100-ci\Sdks\Microsoft.NET.Sdk\Sdk not found. Check that a recent enough .NET SDK is installed and/or increase the version specified in global.json.
        Project "C:\h\w\A10F099F\t\dotnetSdkTests\frorbrtg.sfn\RestartProces---6C6A686B\WatchNoDepsApp.csproj" on node 1 (Restore target(s)).
        C:\h\w\A10F099F\t\dotnetSdkTests\frorbrtg.sfn\RestartProces---6C6A686B\WatchNoDepsApp.csproj : error MSB4236: The SDK 'Microsoft.NET.Sdk' specified could not be found.

@dotnet/domestic-cat is this familiar?

lewing · 2021-12-03T19:12:36Z

@pavelsavara can you take a look

pavelsavara · 2021-12-03T21:07:21Z

I have problems downloading all the binaries necessary to build this repo right now, but I will continue first thing on Monday morning.
I added multiple new files to wasm nuget package and it's manifest, so I think that's the cause. I added at least 8 and renamed few more, So 404 vs 408 doesn't exactly fit. I don't know how this test work yet ...

pavelsavara · 2021-12-04T00:22:44Z

It's the files package.json and dotnet.d.ts which I added to native of the Microsoft.NETCore.App.Runtime.Mono.browser-wasm.7.0.0-dev.nupkg in runtimes\browser-wasm\native. Each of them twice, once as is, and second as .gz, that's why 4 new items in the diff.

The Blazor would put those files into wwwroot\_framework\
I think that they would do not harm in there, but I would prefer to keep them compile time files, not copied to wwwroot.
How is that achieved ?

If we want to leave them there here is change which could probably fix the tests.
#22903

@lewing please advise.

I don't know about NoDepsAppTests

pavelsavara · 2021-12-04T00:26:54Z

libicui18n.a for example is not in wwwroot.

lewing · 2021-12-04T00:53:35Z

This is a rough corner of how we build the runtime pack, I suspect the new files are probably just escaping a work around in the blazor sdk targets. We should fix that but I'd like to solve the underlying problem as well.

cc @TanayParikh @javiercn

…1203.8 Microsoft.NETCore.Platforms , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.App.Runtime.win-x64 , System.CodeDom , System.Security.Cryptography.ProtectedData , System.Resources.Extensions , System.Reflection.MetadataLoadContext , Microsoft.NET.HostModel , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.7.0 , VS.Redist.Common.NetCore.TargetingPack.x64.7.0 From Version 7.0.0-alpha.1.21602.1 -> To Version 7.0.0-alpha.1.21603.8

…1204.4 Microsoft.NETCore.Platforms , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.App.Runtime.win-x64 , System.CodeDom , System.Security.Cryptography.ProtectedData , System.Resources.Extensions , System.Reflection.MetadataLoadContext , Microsoft.NET.HostModel , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.7.0 , VS.Redist.Common.NetCore.TargetingPack.x64.7.0 From Version 7.0.0-alpha.1.21602.1 -> To Version 7.0.0-alpha.1.21604.4

…1206.1 Microsoft.NETCore.Platforms , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.App.Runtime.win-x64 , System.CodeDom , System.Security.Cryptography.ProtectedData , System.Resources.Extensions , System.Reflection.MetadataLoadContext , Microsoft.NET.HostModel , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.7.0 , VS.Redist.Common.NetCore.TargetingPack.x64.7.0 From Version 7.0.0-alpha.1.21602.1 -> To Version 7.0.0-alpha.1.21606.1

TanayParikh · 2021-12-06T16:29:43Z

This is a rough corner of how we build the runtime pack, I suspect the new files are probably just escaping a work around in the blazor sdk targets. We should fix that but I'd like to solve the underlying problem as well.

Thanks @lewing, I've created dotnet/aspnetcore#38844 to track this work. Just to confirm, is this PR currently blocked on us or can dotnet/aspnetcore#38844 be addressed in the new year once people return? cc/ @pavelsavara

danmoseley · 2021-12-06T18:59:08Z

@TanayParikh this PR is blocked on these failures. Its your call whether we wait for the fix or you disable the tests for now.

mkArtakMSFT · 2021-12-06T19:35:26Z

@danmoseley we'll be skipping the test soon. @TanayParikh will put out a PR now

TanayParikh · 2021-12-06T19:47:50Z

bab7dde should unblock this PR for now. Based on @pavelsavara's response #22892 (comment), this seems like expected failures in-light of additional files which aren't yet reflected in our static assets. Skipped the tests as this shouldn't break Blazor (but we will of course lose some coverage in that area until the tests can be re-enabled).

I'll look into #22903 as it's not currently passing CI. dotnet/aspnetcore#38844 tracks the longer term fix.

danmoseley · 2021-12-06T21:17:35Z

Thanks both!

TanayParikh · 2021-12-06T22:56:31Z

The Microsoft.NET.Restore.Tests.RestoreWithOlderNuGet.ItCanBuildProjectRestoredWithNuGet5_7 test is still failing. cc/ @danmoseley

https://dev.azure.com/dnceng/public/_build/results?buildId=1499267&view=ms.vss-test-web.build-test-results-tab&runId=42765622&resultId=101366&paneView=debug

(Note the AoT failures you may see are from a prior test run which is now passing after automatic retry).

danmoseley · 2021-12-06T23:03:41Z

Unable to load the service index for source https://pkgs.dev.azure.com/azure-public/vside/_packaging/vs-buildservices/nuget/v3/index.json.

@MattGal is your Nuget retry work already enabled in this context?

MattGal · 2021-12-06T23:09:52Z

Unable to load the service index for source https://pkgs.dev.azure.com/azure-public/vside/_packaging/vs-buildservices/nuget/v3/index.json.

@MattGal is your Nuget retry work already enabled in this context?

Sorry I don't see this error in the linked builds' attempt #1, can you point me at where you're copying that from?

TanayParikh · 2021-12-06T23:19:08Z

Unable to load the service index for source https://pkgs.dev.azure.com/azure-public/vside/_packaging/vs-buildservices/nuget/v3/index.json.
@MattGal is your Nuget retry work already enabled in this context?

Sorry I don't see this error in the linked builds' attempt #1, can you point me at where you're copying that from?

https://dev.azure.com/dnceng/public/_build/results?buildId=1499267&view=ms.vss-test-web.build-test-results-tab&runId=42765622&resultId=101366&paneView=debug

MattGal · 2021-12-06T23:25:07Z

Unable to load the service index for source https://pkgs.dev.azure.com/azure-public/vside/_packaging/vs-buildservices/nuget/v3/index.json.
@MattGal is your Nuget retry work already enabled in this context?

Sorry I don't see this error in the linked builds' attempt #1, can you point me at where you're copying that from?

https://dev.azure.com/dnceng/public/_build/results?buildId=1499267&view=ms.vss-test-web.build-test-results-tab&runId=42765622&resultId=101366&paneView=debug

Ah in this case @danmoseley I can confirm none of these settings are set on a test machine, and probably should be (by the test). It's actually kind of amazing these tests are as reliable as they seem to be given that. I'll spend a few minutes scratching my head at how they're declared and may make some suggestions.

MattGal · 2021-12-06T23:34:05Z

Suggestion (doesn't have to be part of this PR):

Go here:

https://github.com/dotnet/sdk/blob/main/build/RunTestsOnHelix.sh

Add something like :

export NUGET_ENABLE_EXPERIMENTAL_HTTP_RETRY=true
export NUGET_EXPERIMENTAL_MAX_NETWORK_TRY_COUNT=6
export NUGET_EXPERIMENTAL_NETWORK_RETRY_DELAY_MILLISECONDS=1000

Go here:

https://github.com/dotnet/sdk/blob/main/build/RunTestsOnHelix.cmd

Add something like :

set NUGET_ENABLE_EXPERIMENTAL_HTTP_RETRY=true
set NUGET_EXPERIMENTAL_MAX_NETWORK_TRY_COUNT=6
set NUGET_EXPERIMENTAL_NETWORK_RETRY_DELAY_MILLISECONDS=1000

danmoseley · 2021-12-07T01:07:26Z

@dotnet/domestic-cat are you OK with the edits suggested above ? (thanks @MattGal !)

Context: these just cause Nuget to try harder in the face of network issues. They should not be relevant to whatever the tests are trying to verify. I believe NuGet expects to enable these flags by default in future, as well.

danmoseley · 2021-12-07T01:11:26Z

Pushed those changes up.

dotnet-issue-labeler bot added the Area-CodeFlow label Dec 3, 2021

dotnet-maestro bot added 3 commits December 4, 2021 13:19

TanayParikh mentioned this pull request Dec 6, 2021

Blazor SDK Targets Packaging Fixes dotnet/aspnetcore#38844

Closed

Skip failing Blazor tests

bab7dde

Add Nuget robustness

666502c

TanayParikh mentioned this pull request Dec 7, 2021

Re-enable Skipped Blazor Wasm Tests #22920

Closed

dotnet-maestro bot merged commit 65f3127 into main Dec 7, 2021

dotnet-maestro bot deleted the darc-main-095db280-4d51-4529-ab5e-45572ccf8b07 branch December 7, 2021 03:38

TanayParikh mentioned this pull request Dec 7, 2021

Unskip Blazor Integration Tests #22945

Merged

kasperk81 mentioned this pull request Apr 25, 2022

[main] Update dependencies from dotnet/runtime #24985

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[main] Update dependencies from dotnet/runtime #22892

[main] Update dependencies from dotnet/runtime #22892

dotnet-maestro bot commented Dec 3, 2021 •

edited

Loading

dotnet-maestro bot commented Dec 3, 2021

danmoseley commented Dec 3, 2021 •

edited

Loading

danmoseley commented Dec 3, 2021

lewing commented Dec 3, 2021

pavelsavara commented Dec 3, 2021

pavelsavara commented Dec 4, 2021 •

edited

Loading

pavelsavara commented Dec 4, 2021

lewing commented Dec 4, 2021

TanayParikh commented Dec 6, 2021 •

edited

Loading

danmoseley commented Dec 6, 2021

mkArtakMSFT commented Dec 6, 2021

TanayParikh commented Dec 6, 2021

danmoseley commented Dec 6, 2021

TanayParikh commented Dec 6, 2021

danmoseley commented Dec 6, 2021

MattGal commented Dec 6, 2021

TanayParikh commented Dec 6, 2021

MattGal commented Dec 6, 2021 •

edited

Loading

MattGal commented Dec 6, 2021

danmoseley commented Dec 7, 2021 •

edited

Loading

danmoseley commented Dec 7, 2021

[main] Update dependencies from dotnet/runtime #22892

[main] Update dependencies from dotnet/runtime #22892

Conversation

dotnet-maestro bot commented Dec 3, 2021 • edited Loading

From https://github.com/dotnet/runtime

dotnet-maestro bot commented Dec 3, 2021

Notification for subscribed users from https://github.com/dotnet/runtime:

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

danmoseley commented Dec 3, 2021 • edited Loading

danmoseley commented Dec 3, 2021

lewing commented Dec 3, 2021

pavelsavara commented Dec 3, 2021

pavelsavara commented Dec 4, 2021 • edited Loading

pavelsavara commented Dec 4, 2021

lewing commented Dec 4, 2021

TanayParikh commented Dec 6, 2021 • edited Loading

danmoseley commented Dec 6, 2021

mkArtakMSFT commented Dec 6, 2021

TanayParikh commented Dec 6, 2021

danmoseley commented Dec 6, 2021

TanayParikh commented Dec 6, 2021

danmoseley commented Dec 6, 2021

MattGal commented Dec 6, 2021

TanayParikh commented Dec 6, 2021

MattGal commented Dec 6, 2021 • edited Loading

MattGal commented Dec 6, 2021

Go here:

Add something like :

Go here:

Add something like :

danmoseley commented Dec 7, 2021 • edited Loading

danmoseley commented Dec 7, 2021

dotnet-maestro bot commented Dec 3, 2021 •

edited

Loading

danmoseley commented Dec 3, 2021 •

edited

Loading

pavelsavara commented Dec 4, 2021 •

edited

Loading

TanayParikh commented Dec 6, 2021 •

edited

Loading

MattGal commented Dec 6, 2021 •

edited

Loading

danmoseley commented Dec 7, 2021 •

edited

Loading