-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable ALPN tests/features on MAC #45569
Comments
Yes. There is at least a comment about macOS to remove. There are also a lot of docs that need to be updated. Let's focus on making sure this technically works first before thinking about them. |
We probably want to remove this check which preemptively stops you from binding to HTTP/2-only TLS endpoint on macOS at application startup. We already have logic in Kestrel's HttpConnection to fail at connection start if h2 isn't negotiate via ALPN on a HTTP/2-only TLS endpoint. aspnetcore/src/Servers/Kestrel/Core/src/Middleware/HttpsConnectionMiddleware.cs Lines 466 to 472 in 53124ab
@JamesNK suggests it might make sense to ask for something along the lines of a static IsAlpnSupported property on SslStream to support this use case. |
Consider waiting for dotnet/runtime#79687 before looking at this. Edit: This API will probably take some time to make it through triage/review/implementation. Rather than block this, I think we could have a pretend internal API, and check that in places we currently check for macOS. |
@JamesNK Is this issue at this point just to track using the new proposed runtime API? Should it be remilestoned? |
Updating docs for .NET 8 can happen in preview 1. |
Is there an existing issue for this?
Is your feature request related to a problem? Please describe the problem.
This feature is now available from the runtime so we should consume it in Kestrel.
Describe the solution you'd like
Areas of interest:
Additional context
No response
The text was updated successfully, but these errors were encountered: