Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for macOS + TLS on .NET 8 #28246

Merged
merged 5 commits into from
Jan 31, 2023
Merged

Update docs for macOS + TLS on .NET 8 #28246

merged 5 commits into from
Jan 31, 2023

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Jan 31, 2023

Fixes dotnet/aspnetcore#45569

On some pages, I've left a note that macOS + TLS doesn't work before .NET 8, rather than removing mentioning it completely. I did that because I think there could be people using older versions of .NET who visit those pages to get troubleshooting advice.


:::moniker-end

:::moniker range="< aspnetcore-7.0 < aspnetcore-8.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is causing the build errors, and probably line 78:
:::moniker range=">= aspnetcore-7.0"

That content will get duplicated in 8.0

line 14: :::moniker range="< aspnetcore-8.0"

The monikers don't make sense to me and causing the build error.

@Rick-Anderson
Copy link
Contributor

@JamesNK doesn't look like much is new, mostly copy/paste with new monikers. It helps to point out what needs a review and what's just copy/paste of previous version. Our workflow is typically PR with moniker prep. Add an exact duplicate of the previous version under the updated moniker. S&M. The next PR adds changes for the new version. This approach yields a very good diff that's easy to review what's changed.

* Operating system
* Windows Server 2016/Windows 10 or later&dagger;
* Linux with OpenSSL 1.0.2 or later (for example, Ubuntu 16.04 or later)
* macOS 10.15 or later
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New

Kestrel supports the following scenarios:

* HTTPS
* [HTTP/2](xref:fundamentals/servers/kestrel/http2)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed note about HTTP/2 + macOS

* Operating system
* Windows Server 2016/Windows 10 or later&Dagger;
* Linux with OpenSSL 1.0.2 or later (for example, Ubuntu 16.04 or later)
* macOS 10.15 or later
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New

>
> * Windows
> * Linux
> * macOS
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed note about HTTP/2 + macOS

@@ -8,7 +8,310 @@ uid: tutorials/grpc/grpc-start
---
# Tutorial: Create a gRPC client and server in ASP.NET Core

:::moniker range=">= aspnetcore-6.0"
:::moniker range=">= aspnetcore-8.0"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed a couple of notes about HTTP/2 + macOS

@JamesNK JamesNK merged commit 6fe4ec1 into main Jan 31, 2023
@JamesNK JamesNK deleted the jamesnk/kestrel-tls-macos branch January 31, 2023 09:22
@wadepickett wadepickett mentioned this pull request Mar 8, 2023
7 tasks
Donciavas pushed a commit to Donciavas/AspNetCore.Docs that referenced this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable ALPN tests/features on MAC
2 participants