-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add interop tests to verify that Kestrel's HTTP/2 implementation works with HttpClient's implementation #4763
Comments
Does client mean web browser or web server? |
Browsers are clients, yes. System.Net.Http.HttpClient is the client we prefer for functional tests. |
@Tratcher But now System.Net.Http.HttpClient does not support http2. ( ̄▽ ̄)" |
HttpClient supports http2 on .NET Core for UWP, Linux dotnet/corefx#4756 and Windows dotnet/corefx#10948 (but not Full Framework as yet) |
Note the Windows version restriction as well. |
Limit Http/2 to TLS 1.2 #2251 Bootstrap functional tests #2238
Limit Http/2 to TLS 1.2 #2251 Bootstrap functional tests #2238
Limit Http/2 to TLS 1.2 #2251 Bootstrap functional tests #2238
I did some initial work in #2665 but only for Win10 WinHttpHandler. Linux and Mac have too many dependency issues, we may have to wait for SocketsHttpHandler. |
The remaining test we'd like to add is using new HttpClient. |
We think there's enough support to do this now. |
@Tratcher to follow up on the status of HTTP/2 support in |
@Tratcher turned the existing tests on again 🎉 We do need some additional interop tests that use Trailers. |
This issue is now tracking adding tests that use Trailers to the HttpClient interop test suite. |
HttpClient interop to verify:
|
Moving to preview9 for now. The bar for test-only changes is super low (basically just tell mode) |
We can keep churning on this in master for now. We have a lot of tests now, but @Tratcher's list has some things we still want to cover. We'll look at backporting test coverage if it would be helpful. |
There are not currently any functional test for the Http2 features. We accidentally disabled the entire feature when merging the https and core packages due to a missing TFM and didn't notice. aspnet/KestrelHttpServer#2224
The big blocker here is the lack of consistent client support. However, even if there's one client on one of the OS's then that would be a good start.
The text was updated successfully, but these errors were encountered: