-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make JSON case-insensitive #10727
Merged
Merged
Make JSON case-insensitive #10727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rynowak
commented
Jun 1, 2019
rynowak
commented
Jun 1, 2019
pranavkm
approved these changes
Jun 1, 2019
/azp run AspNetCore-ci |
Azure Pipelines failed to run 1 pipeline(s). |
davidfowl
approved these changes
Jun 1, 2019
/azp run AspNetCore-ci |
Azure Pipelines failed to run 1 pipeline(s). |
/azp run AspNetCore-ci |
Azure Pipelines successfully started running 1 pipeline(s). |
AMAZING THANK YOU |
rynowak
force-pushed
the
rynowak/json-case
branch
from
June 3, 2019 00:06
c397130
to
bbaf905
Compare
mkArtakMSFT
added
the
area-mvc
Includes: MVC, Actions and Controllers, Localization, CORS, most templates
label
Jun 3, 2019
JamesNK
approved these changes
Jun 3, 2019
Fixes: #10724 The rationale for this change is that existing .NET client code for the most part uses JSON.NET with its default settings (preserve property casing). This includes the WebAPI client - which we're encouraging everyone to use. It's not really reasonable for us to break everyone using webapi client.
rynowak
force-pushed
the
rynowak/json-case
branch
from
June 3, 2019 06:17
3ce8522
to
eb886db
Compare
ghost
deleted the
rynowak/json-case
branch
June 3, 2019 16:17
This is in preview6 right? |
yeth |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #10723
The rationale for this change is that existing .NET client code for the
most part uses JSON.NET with its default settings (preserve property
casing). This includes the WebAPI client - which we're encouraging
everyone to use. It's not really reasonable for us to break everyone
using webapi client.