Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make JSON case-insensitive #10727

Merged
merged 5 commits into from
Jun 3, 2019
Merged

Make JSON case-insensitive #10727

merged 5 commits into from
Jun 3, 2019

Conversation

rynowak
Copy link
Member

@rynowak rynowak commented Jun 1, 2019

Fixes: #10723

The rationale for this change is that existing .NET client code for the
most part uses JSON.NET with its default settings (preserve property
casing). This includes the WebAPI client - which we're encouraging
everyone to use. It's not really reasonable for us to break everyone
using webapi client.

@rynowak rynowak requested review from davidfowl and pranavkm June 1, 2019 07:02
@pranavkm
Copy link
Contributor

pranavkm commented Jun 1, 2019

/azp run AspNetCore-ci

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@rynowak
Copy link
Member Author

rynowak commented Jun 1, 2019

/azp run AspNetCore-ci

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@rynowak
Copy link
Member Author

rynowak commented Jun 2, 2019

/azp run AspNetCore-ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rynowak
Copy link
Member Author

rynowak commented Jun 2, 2019

Azure Pipelines successfully started running 1 pipeline(s).

AMAZING THANK YOU

@rynowak rynowak force-pushed the rynowak/json-case branch from c397130 to bbaf905 Compare June 3, 2019 00:06
@mkArtakMSFT mkArtakMSFT added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jun 3, 2019
Ryan Nowak added 5 commits June 2, 2019 23:17
Fixes: #10724

The rationale for this change is that existing .NET client code for the
most part uses JSON.NET with its default settings (preserve property
casing). This includes the WebAPI client - which we're encouraging
everyone to use. It's not really reasonable for us to break everyone
using webapi client.
@rynowak rynowak force-pushed the rynowak/json-case branch from 3ce8522 to eb886db Compare June 3, 2019 06:17
@rynowak rynowak merged commit 670865d into master Jun 3, 2019
@ghost ghost deleted the rynowak/json-case branch June 3, 2019 16:17
@davidfowl
Copy link
Member

This is in preview6 right?

@rynowak
Copy link
Member Author

rynowak commented Jun 3, 2019

yeth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change MVC's use of System.Text.Json to case-insensitive
5 participants