Skip IIS tests that shouldn't be run #12123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotalik
requested review from
analogrelay,
halter73 and
Tratcher
as code owners
|
"RequiresNewHandler"? Newer than what? |
|
We have backcompat tests for having an old shim and an old handler. The old handler is from 2.2.0. |
|
RequiresNewHandler should probably take a min version string or renamed to indicate this means a post-2.2 handler, but I guess I missed the PR where this was added. |
halter73
approved these changes
Jul 12, 2019
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #12042