Remove PlatformAbstractions reference. #20385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributes to dotnet/runtime#3470
ghost
added
the
area-infrastructure
JunTaoLuo
reviewed
Apr 3, 2020
| @@ -29,7 +29,6 @@ and are generated based on the last package release. | |||
| <LatestPackageReference Include="Microsoft.CodeAnalysis.Razor" Version="$(MicrosoftCodeAnalysisRazorPackageVersion)" /> | |||
| <LatestPackageReference Include="Microsoft.CSharp" Version="$(MicrosoftCSharpPackageVersion)" /> | |||
| <LatestPackageReference Include="Microsoft.DotNet.GenAPI" Version="$(MicrosoftDotNetGenApiPackageVersion)" /> | |||
| <LatestPackageReference Include="Microsoft.DotNet.PlatformAbstractions" Version="$(MicrosoftDotNetPlatformAbstractionsPackageVersion)" /> | |||
There was a problem hiding this comment.
Should also remove the entry in Versions.props and Versions.Details.xml.
There was a problem hiding this comment.
Hmm... nvm this package is special in that it doesn't exist elsewhere. Strange.
There was a problem hiding this comment.
Yeah, I was surprised that this was the only reference to PlatformAbstractions in the whole repo. Maybe it was a hold over from previous versions when aspnet actually did reference it. But since 3.0, aspnet hasn't used it.
JunTaoLuo
approved these changes
Apr 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to dotnet/runtime#3470