Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to more recent .NET SDK #21017

Merged
merged 4 commits into from
May 6, 2020
Merged

Upgrade to more recent .NET SDK #21017

merged 4 commits into from
May 6, 2020

Commits on May 4, 2020

  1. Update SDK to preview.5.20251.2 

    - includes support for the `net5.0` TFM
- includes fix for `$(PublishDepsFilePath)`
- includes fix for incorrect NU5118 warnings when `'$(PackAsTool)' == 'true'`
    @dougbu
    dougbu committed May 4, 2020
    Configuration menu
    Copy the full SHA
    e32d7b4 View commit details
    Browse the repository at this point in the history

  2. !!temporary!! Suppress NU5129 warnings 

    - build/ and buildTransitive/ naming conventions do not treat TFMs as equivalent
    @dougbu
    dougbu committed May 4, 2020
    Configuration menu
    Copy the full SHA
    d3caf93 View commit details
    Browse the repository at this point in the history

  3. Run InjectRequestHandlerOnPublish later 

    - late enough for .deps file to exist i.e. after the `CopyFilesToPublishDirectory` target
- `AfterTargets` is a bit flaky; use `BeforeTargets` with empty targets instead
    @dougbu
    dougbu committed May 4, 2020
    Configuration menu
    Copy the full SHA
    cc1c992 View commit details
    Browse the repository at this point in the history

  4. Always add @(AssemblyAttribute) items before they are processed 

    - use `BeforeTargets="GetAssemblyAttributes"` for consistently throughout the repo
    @dougbu
    dougbu committed May 4, 2020
    Configuration menu
    Copy the full SHA
    59fa0dc View commit details
    Browse the repository at this point in the history