Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quarantine dotnet-user-secrets InitCommandTests #21338

Merged
merged 2 commits into from
Apr 30, 2020

Conversation

halter73
Copy link
Member

InitCommandTests caused the latest official build to fail with the following error.

System.InvalidOperationException : Could not load the MSBuild project '/tmp/usersecretstest/a20b03aa-de4a-4b52-8cdb-4fe9cbc456fc/TestProject.csproj'.
at Microsoft.Extensions.SecretManager.Tools.Internal.ProjectIdResolver.Resolve(String project, String configuration) in /_/src/Tools/dotnet-user-secrets/src/Internal/ProjectIdResolver.cs:line 101
at Microsoft.Extensions.SecretManager.Tools.Tests.InitCommandTests.AddsSecretIdToProject() in /_/src/Tools/dotnet-user-secrets/test/InitCommandTest.cs:line 43

@dotnet/aspnet-build

@ghost ghost added the area-commandlinetools Includes: Command line tools, dotnet-dev-certs, dotnet-user-jwts, and OpenAPI label Apr 29, 2020
@BrennanConroy
Copy link
Member

It was only AddsSecretIdToProject that failed not the whole class.
Also, could you do me a favor and add the exit code to the output?

_reporter.Verbose(outputBuilder.ToString());

I have a suspicion that this is the same issue we've been seeing with some 139 exit codes.

@halter73
Copy link
Member Author

halter73 commented Apr 29, 2020

It was only AddsSecretIdToProject that failed not the whole class.

What would cause AddsSecretIdToProject to fail in this way but not AddsSpecificSecretIdToProject, AddsEscapedSpecificSecretIdToProject, etc.?

I'm tempted to quarantine SecretManagerTests too since it uses the same UserSecretsTestFixture, but I updated the PR to quarantine only the tests that both use the fixture and call ProjectIdResolver.Resolve().

Also, could you do me a favor and add the exit code to the output?

Done.

@BrennanConroy
Copy link
Member

BrennanConroy commented Apr 29, 2020

What would cause AddsSecretIdToProject to fail in this way but not AddsSpecificSecretIdToProject, AddsEscapedSpecificSecretIdToProject, etc.?

A race in process exiting. Maybe we should just quarantine the whole thing until the issue is fixed in Runtime...

I downloaded the core dump and it looks like the same issue that is being investigated in dotnet/runtime#34231

@halter73 halter73 closed this Apr 29, 2020
@halter73 halter73 reopened this Apr 29, 2020
@Pilchie
Copy link
Member

Pilchie commented Apr 29, 2020

👀

@halter73 halter73 merged commit 49b4f41 into master Apr 30, 2020
@halter73 halter73 deleted the halter73/quarantine-InitCommandTests branch April 30, 2020 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-commandlinetools Includes: Command line tools, dotnet-dev-certs, dotnet-user-jwts, and OpenAPI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants