Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Templates] Diagnostics improvements and certificate fixes #21493

Merged
merged 6 commits into from
May 6, 2020
Merged

[Templates] Diagnostics improvements and certificate fixes #21493

merged 6 commits into from
May 6, 2020

Conversation

javiercn
Copy link
Member

@javiercn javiercn commented May 5, 2020

  • Move template specific helpers back to templates.
  • Fix casing issue when loading the certificate.
  • Capture startup output and throw when the app can't find the listening URL

@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label May 5, 2020
pranavkm
pranavkm approved these changes May 5, 2020
View reviewed changes
Copy link
Contributor

@pranavkm pranavkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as it works 👍

dougbu
dougbu reviewed May 5, 2020
View reviewed changes
Copy link
Member

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though I have a couple of questions about hidden output / details

src/ProjectTemplates/Shared/AspNetProcess.cs Show resolved Hide resolved
src/ProjectTemplates/Shared/AspNetProcess.cs
}

throw new InvalidOperationException(@$"Couldn't find listening url:
{string.Join(Environment.NewLine, buffer)}");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

src/ProjectTemplates/Shared/AspNetProcess.cs
return RequestWithRetries(client => client.GetAsync(new Uri(ListeningUri, path)), _httpClient);
}
internal Task<HttpResponseMessage> SendRequest(string path) =>
RetryHelper.RetryRequest(() => _httpClient.GetAsync(new Uri(ListeningUri, path)), logger: NullLogger.Instance);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another question about hiding details here…

src/ProjectTemplates/Shared/AspNetProcess.cs Show resolved Hide resolved
@dougbu dougbu mentioned this pull request May 5, 2020
Merged
@dougbu dougbu merged commit d640937 into master May 6, 2020
@dougbu dougbu deleted the javiercn/more-data branch May 6, 2020 02:39
@javiercn
Copy link
Member Author

javiercn commented May 6, 2020

Thanks @dougbu for baby sitting

@dougbu dougbu mentioned this pull request May 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbu dougbu dougbu left review comments

@pranavkm pranavkm pranavkm approved these changes

Assignees
No one assigned
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@javiercn @pranavkm @dougbu